Skip to content

refactor: Change List API into poll based and return one entry instead#3593

Merged
Xuanwo merged 18 commits intomainfrom
polish-lister
Nov 16, 2023
Merged

refactor: Change List API into poll based and return one entry instead#3593
Xuanwo merged 18 commits intomainfrom
polish-lister

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Nov 15, 2023

Close #3236

This introduce the following changes:

  • Change list api into poll based.
  • Return one entry instead of a page.
  • Introduce PageList for better performance.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested review from ClSlaid and suyanhanx November 15, 2023 15:51
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Nov 15, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from xyjixyjixyji as a code owner November 15, 2023 15:55
Comment thread bindings/c/include/opendal.h
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Nov 15, 2023

dropbox test failed for it's rate limit, let's ignore it for now.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner November 15, 2023 16:06
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Nov 16, 2023

Hi, @suyanhanx & @ClSlaid, would you like to take a review?

Copy link
Copy Markdown
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

Comment thread core/src/raw/oio/list/hierarchy_list.rs
Comment thread core/src/docs/upgrade.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking issues of RFC-3232: Align List API

4 participants