Skip to content

feat(core): Implement RFC-3574 Concurrent Stat In List#3599

Merged
Xuanwo merged 19 commits intoapache:mainfrom
morristai:feat/concurrent_stat_in_list
Nov 23, 2023
Merged

feat(core): Implement RFC-3574 Concurrent Stat In List#3599
Xuanwo merged 19 commits intoapache:mainfrom
morristai:feat/concurrent_stat_in_list

Conversation

@morristai
Copy link
Copy Markdown
Member

@morristai morristai commented Nov 16, 2023

Description

Additional Notes

  • I tested, and the entry order remains the same whether concurrent is greater than 1 or concurrent is equal to 1.
  • Regarding the current implementation, I'm not sure whether this will affect the performance when concurrent is equal to 1. If it does, I need some suggestions on the best practices for making changes. 🙏

@morristai morristai requested a review from Xuanwo as a code owner November 16, 2023 05:34
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Nov 16, 2023
@morristai morristai marked this pull request as draft November 16, 2023 05:40
@morristai
Copy link
Copy Markdown
Member Author

morristai commented Nov 16, 2023

Not sure if the test failure is related to the PR.

@morristai morristai marked this pull request as ready for review November 16, 2023 05:43
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 16, 2023

Hi, this PR will need to wait for #3593 which changes the internal API of list.

@Xuanwo Xuanwo changed the title feat(core): concurrent stat in list feat(core): Implement RFC-3574 Concurrent Stat In List Nov 16, 2023
@suyanhanx suyanhanx marked this pull request as draft November 16, 2023 14:32
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Nov 20, 2023

Hi, @morristai, we are going to start a new release recently. Would you like to include this PR inside it?

@morristai
Copy link
Copy Markdown
Member Author

morristai commented Nov 20, 2023

Hi, @morristai, we are going to start a new release recently. Would you like to include this PR inside it?

Give me a day or two; I will merge the master changes.

@morristai morristai marked this pull request as ready for review November 20, 2023 22:47
Xuanwo
Xuanwo reviewed Nov 21, 2023
View reviewed changes
Comment thread core/src/types/list.rs Outdated
Comment thread core/src/types/list.rs Outdated
@morristai morristai force-pushed the feat/concurrent_stat_in_list branch from 14b823a to b886960 Compare November 21, 2023 21:36
Xuanwo
Xuanwo reviewed Nov 22, 2023
View reviewed changes
Comment thread core/src/types/list.rs Outdated
Comment thread core/src/types/list.rs Outdated
Comment thread core/src/types/list.rs Outdated
Comment thread core/src/types/list.rs Outdated
Xuanwo
Xuanwo reviewed Nov 22, 2023
View reviewed changes
Comment thread core/src/types/list.rs Outdated
Comment thread core/src/types/list.rs Outdated
Comment thread core/src/types/list.rs Outdated
@morristai morristai marked this pull request as draft November 23, 2023 00:57
@morristai morristai marked this pull request as ready for review November 23, 2023 01:08
Xuanwo
Xuanwo reviewed Nov 23, 2023
View reviewed changes
Comment thread core/src/types/list.rs
Comment thread core/src/types/list.rs Outdated
Xuanwo
Xuanwo approved these changes Nov 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Xuanwo Xuanwo merged commit 2f98ea6 into apache:main Nov 23, 2023
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking issues of RFC-3574: Concurrent Stat In List

2 participants

@morristai @Xuanwo