Fix runtime return type backward compatibility#5306
Merged
upgle merged 1 commit intoapache:masterfrom Aug 4, 2022
Merged
Conversation
style95
approved these changes
Aug 3, 2022
ningyougang
approved these changes
Aug 3, 2022
Contributor
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #5306 +/- ##
==========================================
+ Coverage 71.46% 76.16% +4.70%
==========================================
Files 238 238
Lines 14183 14178 -5
Branches 574 579 +5
==========================================
+ Hits 10136 10799 +663
+ Misses 4047 3379 -668
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
msciabarra
pushed a commit
to nuvolaris/openwhisk
that referenced
this pull request
Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some downstream runtimes may not support the array return type.
(This also happens when using a legacy action loop base.)
In this case, test case will fail and you will be inconvenient for maintaining.
I think it is should be preserved backward compatibility.
Related issue and scope
#5290
My changes affect the following components
Types of changes
Checklist: