-
Notifications
You must be signed in to change notification settings - Fork 506
ORC-1001: Bump maven-enforcer-plugin to 3.0.0 #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-1001: Bump maven-enforcer-plugin to 3.0.0 #910
Conversation
|
I think the JDK17 General-Availability Release was released two days ago. Github workflow updated JDK17. Now System.getProperty("java.version") returns "17" which causes a lot of program exceptions. For example org.apache.hadoop.util.Shell.java java.lang.StringIndexOutOfBoundsException: String index out of range: 3 |
|
Oh, I didn't see your PR and made a PR to upgrade Java 17. |
|
Actually, this is very unfortunate situation because we released Apache ORC 1.7.0. :( |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least, I verified that this PR recover compile and package (without tests).
Thank you, @autumnust .
java/pom.xml
Outdated
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-enforcer-plugin</artifactId> | ||
| <version>3.0.0-M3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use 3.0.0.
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @autumnust and @guiyanakuang .
We can fix the issue step by step.
@dongjoon-hyun, probably JDK official will fix this problem, because there are many programs involved. It should not be necessary for each program to upgrade the Java version judgment. So don't worry about the ORC 1.7.0 compatibility issue. |
|
BTW, |
|
Do you have any reference for that? Actually, Java community is a little notorious because they don't care about that many programs, @guiyanakuang . |
|
@dongjoon-hyun I remember a similar thing happening with JDK 9. I always thought it was the JDK that officially solved the version number problem. I just googled it and I was wrong. : ( |
|
Oh, I misread the message and deleted my previous comment~ If you received them via the email, please forget about that. |
|
BTW, this might be only our test framework issue. Let me dig more. |
|
Yes, there is no code directly related to java version in ORC, the example I gave is from hadoop 2.2. It has been fixed at https://issues.apache.org/jira/browse/HADOOP-14586. Don't worry too much. |
|
Ya, that could be one reason to raise the BTW, for Java 17 testing, I'll add a |
What changes were proposed in this pull request?
While working on another PR, I found the head of main failed in GA with the failure like below.
Google a bit and found a similar issue: apache/accumulo-proxy#19
This PR is a draft to see if the same change could work here ( since I don't have specific env like failed CI)
Why are the changes needed?
Recover
compileandpackagewithout tests.How was this patch tested?
Manual.