ORC-1000: Use Java 17 in GitHub Action #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Sep 16, 2021
| set(JAVA_TEST_PROFILE -Pcmake,java17) | ||
| set(ADD_OPENS --add-opens) | ||
| set(JAVA_NIO java.base/java.nio=ALL-UNNAMED) | ||
| endif() |
Member
Author
|
cc @williamhyun and @guiyanakuang |
Member
|
+1 LGTM. |
Member
Author
|
Thank you so much, @guiyanakuang ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 16, 2021
### What changes were proposed in this pull request? This PR aims the following. - Use `Java 17` instead of `Java 17 EA`. - Remove `Java 16` to save the community testing resources - Recover GitHub Action CI by using `java17` profile. - Disable dependency check on `hadoop-hdfs` of `shim` module Note that there is a TODO (ORC-1003) which fails due to some `shaded` classes. We will revisit that. ### Why are the changes needed? Java 17 is finally available. ### How was this patch tested? Pass the CIs with Java 17. When we test manually, it passed like the following. ``` $ java -version openjdk version "17" 2021-09-14 LTS OpenJDK Runtime Environment Zulu17.28+13-CA (build 17+35-LTS) OpenJDK 64-Bit Server VM Zulu17.28+13-CA (build 17+35-LTS, mixed mode, sharing) ... Test project /Users/dongjoon/APACHE/orc-merge/build Start 1: orc-test 1/7 Test #1: orc-test ......................... Passed 3.41 sec Start 2: java-test 2/7 Test #2: java-test ........................ Passed 97.92 sec Start 3: java-tools-test 3/7 Test #3: java-tools-test .................. Passed 0.11 sec Start 4: java-bench-gen-test 4/7 Test #4: java-bench-gen-test .............. Passed 0.98 sec Start 5: java-bench-scan-test 5/7 Test #5: java-bench-scan-test ............. Passed 0.67 sec Start 6: java-bench-hive-test 6/7 Test #6: java-bench-hive-test ............. Passed 12.47 sec Start 7: tool-test 7/7 Test #7: tool-test ........................ Passed 10.02 sec 100% tests passed, 0 tests failed out of 7 Total Test time (real) = 125.58 sec Built target test-out ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims the following.
Java 17instead ofJava 17 EA.Java 16to save the community testing resourcesjava17profile.hadoop-hdfsofshimmoduleNote that there is a TODO (ORC-1003) which fails due to some
shadedclasses.We will revisit that.
Why are the changes needed?
Java 17 is finally available.
How was this patch tested?
Pass the CIs with Java 17.
When we test manually, it passed like the following.