Skip to content

Conversation

@abhishekaypurohit
Copy link
Contributor

What changes were proposed in this pull request?

The SCM HA needs the ability to represent a group as a single entity. So that Tokens for each of the OM which is part of an HA group can be honored by the data nodes.
This patch adds service name support for CSR in OzomeManager.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2442

How was this patch tested?

Updated corresponding unit tests and tested them by running those tests.

@dineshchitlangia
Copy link
Contributor

@abhishekaypurohit Thank you for working on this jira. In future, when you address the review comments, pls try avoid force-push. Multiple commits make it easy for reviewers to review the incremental changes. The committer will take care to Squash&Merge your change.
:) Thank you!

@abhishekaypurohit
Copy link
Contributor Author

@abhishekaypurohit Thank you for working on this jira. In future, when you address the review comments, pls try avoid force-push. Multiple commits make it easy for reviewers to review the incremental changes. The committer will take care to Squash&Merge your change.
:) Thank you!

Will keep that in mind. Each team has different style :)

@anuengineer
Copy link
Contributor

The failed unit test has been fixed in the trunk and is not related to this patch. I am going to commit this change.

@anuengineer anuengineer merged commit c3b14f6 into apache:master Nov 19, 2019
@adoroszlai
Copy link
Contributor

Unfortunately this is a case where the known failing tests hide a newly introduced failure. TestSecureOzoneCluster has been failing recently (being fixed in #207). However, the following two failures are related to this patch:

testDelegationToken(org.apache.hadoop.ozone.TestSecureOzoneCluster)  Time elapsed: 4.405 s  <<< ERROR!
java.io.IOException: DestHost:destPort localhost:9862 , LocalHost:localPort pr-hdds-2442-62n7p-2882829386/192.168.157.225:0. Failed on local exception: java.io.IOException: org.apache.hadoop.security.AccessControlException: Client cannot authenticate via:[TOKEN, KERBEROS]

https://github.com/elek/ozone-ci-03/blob/b44bc5fe755201d85802dcf23c977f49bcbe0a57/pr/pr-hdds-2442-62n7p/integration/hadoop-ozone/integration-test/org.apache.hadoop.ozone.TestSecureOzoneCluster.txt#L95-L147

and

testDelegationTokenRenewal(org.apache.hadoop.ozone.TestSecureOzoneCluster)  Time elapsed: 12.462 s  <<< ERROR!
TOKEN_ERROR_OTHER org.apache.hadoop.ozone.om.exceptions.OMException: Get delegation token failed.

https://github.com/elek/ozone-ci-03/blob/b44bc5fe755201d85802dcf23c977f49bcbe0a57/pr/pr-hdds-2442-62n7p/integration/hadoop-ozone/integration-test/org.apache.hadoop.ozone.TestSecureOzoneCluster.txt#L326-L367

I'm reverting (in the other PR) the config added to TestSecureOzoneCluster in this PR, because I couldn't come up with a fix in a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants