HDDS-2522. Fix TestSecureOzoneCluster #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Contributor
|
Change LGTM, +1 thanks @adoroszlai for fixing this. |
dineshchitlangia
requested changes
Nov 20, 2019
Contributor
dineshchitlangia
left a comment
dineshchitlangia
left a comment
There was a problem hiding this comment.
@adoroszlai thanks for your contribution. It seems there is compilation failure.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestSecureOzoneCluster.java
Show resolved
Hide resolved
… it breaks token delegation tests
dineshchitlangia
approved these changes
Nov 20, 2019
Contributor
dineshchitlangia
left a comment
dineshchitlangia
left a comment
There was a problem hiding this comment.
+1 LGTM. Thanks @xiaoyuyao for reviews and @adoroszlai for the fixes.
Contributor
Author
|
Thanks @xiaoyuyao and @dineshchitlangia for reviewing this. |
vivekratnavel
pushed a commit
to vivekratnavel/hadoop-ozone
that referenced
this pull request
Nov 21, 2019
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Dec 3, 2025
…apache#207) (cherry picked from commit 37273d1) Change-Id: I964a933d7d20fa8583bb2adf43f766ef0a298111 Co-authored-by: Tsz-Wo Nicholas Sze <szetszwo@apache.org> (cherry picked from commit ff717e2910677a6b3629a3ee9475258c2fcc5388)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
TestSecureOzoneCluster, failing because it used the wrong principal for SCM.Plus code cleanup in additional commit.
https://issues.apache.org/jira/browse/HDDS-2522
How was this patch tested?
TestSecureOzoneClusternow passes . No other code changed.