Skip to content

HDDS-4882. Introduce the ReplicationConfig and modify the proto files #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elek wants to merge 5 commits into from
Closed

HDDS-4882. Introduce the ReplicationConfig and modify the proto files #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41b7fca
ec proto changes
elek Mar 1, 2021
a5ec416
fixing typo
elek Mar 1, 2021
2fe4f34
fix typo
elek Mar 8, 2021
2589d41
configuration object for standalone replication
elek Mar 9, 2021
c0e9a2f
move replication indexes to a separated PR
elek Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions hadoop-hdds/interface-client/src/main/proto/hdds.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,13 +228,29 @@ enum ReplicationType {
RATIS = 1;
STAND_ALONE = 2;
CHAINED = 3;
EC = 4;
}

//Deprected: we should use replication config implementations everywhere
enum ReplicationFactor {
ONE = 1;
THREE = 3;
}

//replicaiton config for Ratis replication. Will replace pure ReplicationType everywhere
message RatisReplicationConfig {
required ReplicationFactor factor = 1;
}

message StandaloneReplicationConfig {
required ReplicationFactor factor = 1;
}

message ECReplicationConfig {
required int32 data = 1;
required int32 parity = 2;
}

enum ScmOps {
allocateBlock = 1;
keyBlocksInfoList = 2;
Expand Down
10 changes: 9 additions & 1 deletion hadoop-hdds/interface-server/src/main/proto/ScmServerProtocol.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,18 @@ enum Status {
message AllocateScmBlockRequestProto {
required uint64 size = 1;
required uint32 numBlocks = 2;

//deprecated, use RatisReplicationConfig
required ReplicationType type = 3;
required hadoop.hdds.ReplicationFactor factor = 4;

optional hadoop.hdds.ReplicationFactor factor = 4;
required string owner = 5;
optional ExcludeListProto excludeList = 7;

//based on replication type, at least one of these should be included
optional hadoop.hdds.RatisReplicationConfig ratisReplicationConfig = 8;
optional hadoop.hdds.ECReplicationConfig ecReplicationConfig = 9;
optional hadoop.hdds.StandaloneReplicationConfig standaloneReplicationConfig = 10;
}

/**
Expand Down