HDDS-5206. Support revoking S3 secret #2239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smengcl
commented
May 12, 2021
...ager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3RevokeSecretRequest.java
Outdated
Show resolved
Hide resolved
smengcl
commented
May 12, 2021
...er/src/main/java/org/apache/hadoop/ozone/om/response/s3/security/S3RevokeSecretResponse.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
May 12, 2021
...ager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3RevokeSecretRequest.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
May 12, 2021
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/s3/RevokeS3SecretHandler.java
Show resolved
Hide resolved
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
Overall LGTM.
I have few comments/questions.
...ager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3RevokeSecretRequest.java
Show resolved
Hide resolved
...ager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3RevokeSecretRequest.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/s3/RevokeS3SecretHandler.java
Show resolved
Hide resolved
Invalid entry in table cache immediately (Thanks Aravindan); Impl. isAdmin in OzoneManager. Change-Id: Ia5c8d76be0845c5530d1e84abd82217be7797141
smengcl
changed the title
Change-Id: Idb7ac40b974380a43946930bb4742d44696cfcea
Conflicts: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServlet.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServlet.java Change-Id: If923f83358898f3d084a38a70d40fa197e8b2103
Change-Id: I8fe03516379f9094769633b82a8a77e06e8a809b
Contributor
Author
|
@xiaoyuyao @bharatviswa504 I have addressed all comments. Please take another look. Thanks! |
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java
Outdated
Show resolved
Hide resolved
...manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3GetSecretRequest.java
Outdated
Show resolved
Hide resolved
...manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3GetSecretRequest.java
Outdated
Show resolved
Hide resolved
Change-Id: I1d6e054010e7046299e65f8bef1d341eb60e5ea8
vivekratnavel
approved these changes
May 19, 2021
...manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3GetSecretRequest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @xiaoyuyao @bharatviswa504 @vivekratnavel for reviewing this. Will merge shortly. |
Contributor
Author
|
Just realized I have a typo in the permission check, should be |
bharatviswa504
pushed a commit
to bharatviswa504/hadoop-ozone
that referenced
this pull request
Jul 25, 2021
(cherry picked from commit 4fd8187) Change-Id: I97158a39ed50614706a5615d1019b07501cf45ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDDS-5206
Currently the CLI only support "ozone s3 getsecret", but has no user or admin command to revoke the secret, or to rotate the secret. Add a new command to do that.