HDDS-5206. Addendum: Support revoking S3 secret #2270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
May 20, 2021
...manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3GetSecretRequest.java
Outdated
Show resolved
Hide resolved
Change-Id: Id589dd30789fd49199f54bb2b472d024140fb48c
adoroszlai
approved these changes
May 22, 2021
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @smengcl for updating the patch, LGTM.
Contributor
Author
|
Thank you @adoroszlai for reviewing. |
bharatviswa504
pushed a commit
to bharatviswa504/hadoop-ozone
that referenced
this pull request
Jul 25, 2021
(cherry picked from commit e00fa80) Change-Id: I6c56a001f5d34dc9933e8db81f5b61c3e6f4a190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addendum to #2239 .
Fixes the typo which wasn't caught in the previous review for s3 getsecret / revokesecret admin permission check.