HDDS-9252. NPE in TestNSSummaryTaskWithLegacy. #5273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @ArafatKhan2198 for working on this. Please see #5283 for a solution that keeps the nested test structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The structure of
TestNSSummaryTaskWithLegacyis nested, with separate inner classes for each "process" and "reprocess" scenario. This differs from the design of other test classes, such asTestFileSizeCountTask,TestContainerSizeCountTask, andTestContainerKeyMapperTask, which consolidate these scenarios for the sake of code simplicity.As a result of this nested structure, the inner classes rely on the setup method of the outer class. This creates a problem because, due to its dependencies on other test classes, it cannot execute independently. Consequently, a NullPointerException (NPE) error occurs because some instances are not properly initialized.
To address this issue, we have considered refactoring the class to follow a pattern similar to other test classes that are not nested, thereby eliminating the dependency on the outer class's setup method.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9252
How was this patch tested?
The test cases passed correctly