-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-9252. NPE in TestNSSummaryTask #5283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ArafatKhan2198 alternative fix for HDDS-9252, keeping nested test structure |
hemantk-12
approved these changes
Sep 15, 2023
Contributor
hemantk-12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
Contributor
Author
|
Thanks @hemantk-12 for the review. |
This was referenced Oct 31, 2023
Closed
This was referenced Oct 9, 2025
This was referenced Nov 6, 2025
This was referenced Nov 14, 2025
This was referenced Nov 26, 2025
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Dec 3, 2025
This was referenced Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestNSSummaryTaskand related tests are implemented as nested classes. If we run the nested test class directly (either explictly, or via some selector, e.g. package name), these nested classes run into exceptions, because JUnit does not execute the@BeforeClasssetup code in the outer class.This change converts these tests to JUnit5, which handles nested class setup properly.
https://issues.apache.org/jira/browse/HDDS-9252
How was this patch tested?
CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/6163907068/job/16728478679