HDDS-9698. Skip push build for dependabot #5608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
approved these changes
Nov 15, 2023
Contributor
Author
|
Thanks @kaijchen, @kerneltime for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
dependabot pushes dependency version bumps to the main repo instead of its own fork. It then creates a pull request without waiting for the
pushworkflow to succeed. Thus both workflows test the same state of code, which is unnecessary.I propose completely skipping
pushbuild for dependabot's changes to save CI resources.https://issues.apache.org/jira/browse/HDDS-9698
How was this patch tested?
Build skipped in branch
dependabot-HDDS-9698in my fork:https://github.com/adoroszlai/ozone/actions/runs/6876171772
but ran normally in branch
HDDS-9698:https://github.com/adoroszlai/ozone/actions/runs/6876180867
as well as for PR created from branch
dependabot-HDDS-9698:https://github.com/adoroszlai/ozone/actions/runs/6876212003