Skip to content

HDDS-12432. [DiskBalancer] Respect property "hdds.datanode.disk.balancer.max.disk.throughputInMBPerSec" #8006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChenSammi merged 4 commits into from
Mar 11, 2025
Merged

HDDS-12432. [DiskBalancer] Respect property "hdds.datanode.disk.balancer.max.disk.throughputInMBPerSec" #8006

ChenSammi merged 4 commits into from
Mar 11, 2025

Conversation

@Gargi-jais11
Copy link
Contributor

@Gargi-jais11 Gargi-jais11 commented Mar 5, 2025

What changes were proposed in this pull request?

Current DiskBalancerService#balancedBytesInLastWindow is always 0. Throttling configuration "hdds.datanode.disk.balancer.max.disk.throughputInMBPerSec" is not respected.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12432

How was this patch tested?

The patch was tested manually on docker cluster by adding log for debugging.

2025-03-04 12:46:23 2025-03-04 07:16:23,611 [DiskBalancerService#3] INFO diskbalancer.DiskBalancerService: Skipping balancing until nextAvailableTime (8628818)
2025-03-04 12:46:23 2025-03-04 07:16:23,611 [47aaddad-75cb-42a0-8e02-cde1309ca6d2-BlockDeletingService#2] INFO interfaces.ContainerDeletionChoosingPolicyTemplate: Chosen 0/5000 blocks from 0 candidate containers.
2025-03-04 12:47:23 2025-03-04 07:17:23,611 [DiskBalancerService#3] INFO diskbalancer.DiskBalancerService: Skipping balancing until nextAvailableTime (8628818)
2025-03-04 12:47:23 2025-03-04 07:17:23,611 [47aaddad-75cb-42a0-8e02-cde1309ca6d2-BlockDeletingService#2] INFO interfaces.ContainerDeletionChoosingPolicyTemplate: Chosen 0/5000 blocks from 0 candidate containers.
2025-03-04 12:48:23 2025-03-04 07:18:23,610 [DiskBalancerService#3] INFO diskbalancer.DiskBalancerService: Skipping balancing until nextAvailableTime (8628818)
2025-03-04 12:48:23 2025-03-04 07:18:23,610 [47aaddad-75cb-42a0-8e02-cde1309ca6d2-BlockDeletingService#2] INFO interfaces.ContainerDeletionChoosingPolicyTemplate: Chosen 0/5000 blocks from 0 candidate containers.

@Gargi-jais11 Gargi-jais11 marked this pull request as ready for review March 5, 2025 05:28
@Gargi-jais11 Gargi-jais11 requested a review from ChenSammi March 10, 2025 12:02
ChenSammi
ChenSammi approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@ChenSammi ChenSammi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gargi-jais11 .

@ChenSammi ChenSammi merged commit 8a16109 into apache:HDDS-5713 Mar 11, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChenSammi ChenSammi ChenSammi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gargi-jais11 @ChenSammi