Skip to content

HDDS-12432. [DiskBalancer] Respect property "hdds.datanode.disk.balancer.max.disk.throughputInMBPerSec" #8006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenSammi merged 4 commits into from
Mar 11, 2025
Merged

HDDS-12432. [DiskBalancer] Respect property "hdds.datanode.disk.balancer.max.disk.throughputInMBPerSec" #8006

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62716ef
HDDS-12432. [DiskBalancer] Respect property hdds.datanode.disk.balanc…
Mar 2, 2025
5b22197
HDDS-12432. [DiskBalancer] Respect property hdds.datanode.disk.balanc…
Mar 4, 2025
ce44651
HDDS-12432. [DiskBalancer] Respect property hdds.datanode.disk.balanc…
Mar 10, 2025
e053793
Update DiskBalancerService.java
Gargi-jais11 Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...ice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,17 +363,24 @@ public BackgroundTaskQueue getTasks() {
private boolean shouldDelay() {
// We should wait for next AvailableTime.
if (Time.monotonicNow() <= nextAvailableTime.get()) {
if (LOG.isDebugEnabled()) {
LOG.debug("Skipping balancing until nextAvailableTime ({} ms)",
(nextAvailableTime.get() - Time.monotonicNow()));
}
return true;
}
// Calculate the next AvailableTime based on bandwidth
long bytesBalanced = balancedBytesInLastWindow.getAndSet(0L);

final int megaByte = 1024 * 1024;

// converting disk bandwidth in byte/millisec
float bytesPerMillisec = bandwidthInMB * megaByte / 1000f;
nextAvailableTime.set(Time.monotonicNow() +
((long) (bytesBalanced / bytesPerMillisec)));
long delayInMillisec = (long) (bytesBalanced / bytesPerMillisec);
nextAvailableTime.set(Time.monotonicNow() + delayInMillisec);
if (LOG.isDebugEnabled()) {
LOG.debug("Bytes balanced: {} MB, Calculated delay: {} ms ({} sec)",
bytesBalanced / megaByte, delayInMillisec, delayInMillisec / 1000);
}
return false;
}

Expand Down Expand Up @@ -446,6 +453,7 @@ public BackgroundTaskResult call() {
}
oldContainer.getContainerData().getVolume()
.decrementUsedSpace(containerSize);
balancedBytesInLastWindow.addAndGet(containerSize);
metrics.incrSuccessCount(1);
metrics.incrSuccessBytes(containerSize);
} catch (IOException e) {
Expand Down