Skip to content

Conversation

@jojochuang
Copy link
Contributor

@jojochuang jojochuang commented Jul 2, 2025

What changes were proposed in this pull request?

HDDS-13369. [Docs] Maintenance mode.

Please describe your PR in detail:

  • Create a Maintenance mode user doc.
  • Generated-by: Google Gemini Cli, Gemini 2.5 Flash; Prompt:

Read the jira https://issues.apache.org/jira/browse/HDDS-13369 and implement it.

The command line CLI in the doc seems inaccurate. Check out the source code of MaintenanceSubCommand and fix the errors.
The configuration properties in the doc seems wrong. Use the source code for ReplicationManager and look up properties relevant to maintenance mode, and update the doc.
Add default values too.
Are there any metrics relevant to maintenance mode and recommission? Mention them in the doc too.

Number of tokens used:


│  Input Tokens         1,296,322  │
│  Output Tokens            3,832  │
│  Thoughts Tokens          2,991  │
│  ──────────────────────────────  │
│  Total Tokens         1,303,145  │
│                                  │
│  Total duration (API)    1m 37s  │

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13369

How was this patch tested?

Draft prepared by Gemini Cli; Manually reviewed and updated.

Change-Id: I9cf85e7f8fc8f0f4d8f69f6e27b47cfb8fed822c
@jojochuang jojochuang added documentation Improvements or additions to documentation AI-gen labels Jul 2, 2025
@adoroszlai adoroszlai removed their request for review July 3, 2025 07:10
Clarify that Datanodes in maintenance mode can still serve reads.

Change-Id: I14b5ad21e7760848376f26442a8c4d57b56a9ff6
@jojochuang
Copy link
Contributor Author

@aryangupta1998 please check again.

Copy link
Contributor

@aryangupta1998 aryangupta1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a minor suggestion!


## Command Line Usage

To place a DataNode into maintenance mode, use the `ozone admin datanode maintenance` command. You can specify a duration for the maintenance period. If no duration is specified, a default duration will be used (this can be configured).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add the default value of the default duration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default is indefinitely. See line 53.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jojochuang jojochuang merged commit 1159d9b into apache:master Jul 11, 2025
14 checks passed
@jojochuang
Copy link
Contributor Author

Merged. Thanks @ayushtkn @aryangupta1998

jojochuang added a commit to jojochuang/ozone that referenced this pull request Jul 31, 2025
Generated-by: Google Gemini Cli, Gemini 2.5 Flash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-gen documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants