Skip to content

Conversation

@jojochuang
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-13641. [Docs] Include configurations and metrics related to DataNode decommission

Please describe your PR in detail:

  • Similar to HDDS-13369. [Docs] Maintenance mode. #8728, add configuration properties that controls decommission speed. The configs are defined in ReplicationServer and ReplicationManager, and add metrics (ReplicationManagerMetrics, MeasuredReplicator) related to decommission so that administrators.
  • Cross referenced the actual Prometheus metric name in a physical cluster.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13641

How was this patch tested?

Doc only

Adds a new section to the DataNode decommissioning documentation that details relevant configuration properties and metrics.

This information allows administrators to tune the speed of the decommissioning process and monitor its status effectively.

Change-Id: Idc5c8fb7b3a9c84bdea61edc3620b245b0b0de19
This commit further refines the metrics documentation for DataNode decommissioning by:

- Adding more relevant metrics from MeasuredReplicator.
- Correcting the Prometheus metric names based on user feedback.
- Clarifying the descriptions and removing unused metrics.

Change-Id: I84387e00c0c211d880f0e0aa580e756b187ab75b
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for configuration properties and metrics related to DataNode decommissioning in Apache Ozone. It provides administrators with tuning and monitoring guidance for the decommission process.

  • Added comprehensive configuration properties section for both SCM-side and DataNode-side settings
  • Documented monitoring metrics for ReplicationManagerMetrics and MeasuredReplicator components
  • Included corresponding Prometheus metric names for practical cluster monitoring

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

jojochuang and others added 3 commits September 8, 2025 12:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jojochuang jojochuang marked this pull request as ready for review September 8, 2025 19:14
@github-actions
Copy link

This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label Nov 11, 2025
Copy link
Contributor

@sodonnel sodonnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it needs a conflict resolved before we can commit.

@sodonnel sodonnel merged commit 6d0288b into apache:master Nov 11, 2025
15 checks passed
@ivandika3 ivandika3 removed the stale label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants