HDDS-13929. Modularise Snapshot Delta file computer (Efficient Diff) #9312

swamirishi · 2025-11-17T14:41:11Z

What changes were proposed in this pull request?

Modularise SnapshotDiff computation for figuring out delta files between 2 snapshots for efficient diff. Create a CompositeDiffComputer which would be responsible for computing delta files between 2 snapshots.
This is built on top of #9283

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13929

How was this patch tested?

Added unit test

Change-Id: Iba47aeb21663dfa407ab71339cef02c0d74b49f2

Change-Id: Ifd2feca1fddb144e4955db025f0b15a2ab1f3bfe

Change-Id: I34536ff06efb7d5a4942853f0fd83942ab398b5f

…otLocalDataManager Change-Id: I34536ff06efb7d5a4942853f0fd83942ab398b5f

Change-Id: I32bcaf2a1fb290f1790c02872a0230cd65586636

Change-Id: I105a2e8178c0444d52de41b99801f4ceb6d57ffd # Conflicts: # hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/Checksum.java # hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/ObjectSerializer.java # hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/YamlSerializer.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotLocalDataYaml.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java # hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshotLocalDataYaml.java

Change-Id: I985170e38fb8beeb784048e85a08a4c79e1aec97

Change-Id: I33e6e6e825bf23c323ad7ed593d800a11720fa4f

Change-Id: If30b2c766db82adde72145c8ecd3e590ef54cc2d

Change-Id: Id3f2c49050bc3476b9e0f5f51dacb6d9acc4c2f7

Change-Id: I432960725b4c6c55aa906b5780cc3027e41e10db

Change-Id: I3c5514e5bbd251a2b5297d8f074cfde5c71fa543

Change-Id: Ib5a9e6c91bdccba17820263c47eaf2c8400e930d

Change-Id: Ica36e0615c7bc6aa9b6a7f6fafafd0f830d4bafb

Change-Id: I26b66f266bb7677e4b1078f5fcd9f2ce3a651a70 # Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java

Change-Id: I1d93dbc048a42cc55ff1f8ffa420e52f967527b8

Change-Id: I34202928a7a367dd0a1e57219317ff34de352b78

Change-Id: Iad6f26cb71ec921c51ee2d138745df1a2663533f

Change-Id: Ic5f7e249cfb9cb3973cbcd4abd36b22a6ff8f5aa

…calDataProvider Change-Id: I3a004b4b435075a4348960aeed642e8da71e7e72

Change-Id: I06990bc9ab8fc7e1eb7bec255646a650bd8c35fe

Change-Id: I4c6c61c83aa9fadab8ecef854b99dcc0a89a2208

Change-Id: I0e476322372a302572f1fe79cbf2e874bfeac2ed

Change-Id: I31004e0c95dad64411c6fe848501a82f2f773cba

Change-Id: Id317c8b56e8b25c122b68eaf96599b9690d08f79

Change-Id: I3849387d064e093634e69cdaf870d27c1934cda5 # Conflicts: # hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/ObjectSerializer.java # hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/YamlSerializer.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotLocalData.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotLocalDataYaml.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java

Change-Id: Ie5e5f3dab4324103e8855dd15619d7755f0422e6

Change-Id: I55bd5c3ef7fc32910a9111328638de2edffcd541

Change-Id: I880997d3eebdf378f14c203c61c2d63b2d17552e

Change-Id: I13ba8e2fd012a3c964d657e83496c93a4f55a3be

Change-Id: I47fca4c2ca1738b533992851fa54291cb109cc39

Change-Id: Id07b78b650ce58fcc71bbac478d085b139123b02

Change-Id: Iacf5dd1fd2013d6203ea7003645cb79433186519

Change-Id: I22a212c84a3dbcd66a8e61a940d4df239b73133f

Change-Id: I4ab5c3d469b3729271ccccdf926699ec94b96e21

Change-Id: I857831bebe3a733d28998606cbf3f1b0676b2ba5

Change-Id: Idc5174ef66392fe16693aa8799aa51db7277a0e0 # Conflicts: # hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/RdbUtil.java # hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/SstFileInfo.java # hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java # hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDiffUtils.java

Change-Id: I4c023aeca7771fe6f65cb09f62a6253583c0d278 # Conflicts: # hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDiffUtils.java

Change-Id: I6bedaf83ebfc65f46a7c3fd298fa7dc5f26d7fd1

Change-Id: Ib313080b2ffa2f6e7545ae817f5e456cabc5dba7

Change-Id: I41308fd260de2e7ecdd8e8318e2155096212b687

Change-Id: Ie464f0ed154e8911024dbe7802338e11a83f502a

jojochuang · 2025-11-18T22:11:26Z

...-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/RDBDifferComputer.java

+            snapProvider.getSnapshotLocalData());
+        final Map<Integer, Integer> versionMap = snapProvider.getSnapshotLocalData().getVersionSstFileInfos().entrySet()
+            .stream().collect(toMap(Map.Entry::getKey, entry -> entry.getValue().getPreviousSnapshotVersion()));
+        synchronized (differ) {


is this necessary? getSSTDiffListWithFullPath() is a synchronized method.

yeah this is required since we are creating the hardlink in this method and not inside rocksdb checkpoint differ. The files could get deleted by then from the dag

jojochuang · 2025-11-18T22:16:39Z

...src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/CompositeDeltaDiffComputer.java

+            tablePrefixInfo).orElse(null);
+      }
+    } catch (Exception e) {
+      LOG.error("Falling back to full diff.", e);


it should be a WARN if this operation can continue with the fallback approach.

jojochuang · 2025-11-19T17:17:43Z

Also please rebase the PR

Change-Id: I3e885ef24c95280ea0acccaf44787bd295aedbe4 # Conflicts: # hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/IOUtils.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/DeltaFileComputer.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/FileLinkDeltaFileComputer.java

Change-Id: I6ae5c5897f9ca8580ba68b17ad77dffa35dfafb6

Change-Id: Ib6089c9c7d8c787edd75721234d94d1ea0eb88c9

Copilot

Pull Request Overview

This pull request modularizes snapshot delta file computation by introducing a compositional architecture for computing SST file differences between two Ozone snapshots. The refactoring extracts the monolithic diff computation logic from SnapshotDiffManager into dedicated, reusable components.

Creates CompositeDeltaDiffComputer that orchestrates between efficient RocksDB DAG-walk differ and fallback full-diff strategies
Introduces RDBDifferComputer for efficient SST file delta computation using RocksDB's checkpoint differ
Extracts FullDiffComputer as a fallback mechanism for exhaustive file-by-file comparison
Updates method signatures to use Path instead of String for file references, improving type safety

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
`CompositeDeltaDiffComputer.java`	New orchestrator class implementing composite pattern for delta file computation with RDBDiffer and FullDiff strategies
`RDBDifferComputer.java`	New implementation for efficient SST file delta computation using RocksDB checkpoint differ
`FileLinkDeltaFileComputer.java`	Updated abstract base class with renamed field `tmpDeltaFileLinkDir` and improved documentation
`FullDiffComputer.java`	Updated diff computer with enhanced documentation explaining delta file computation semantics
`TestRDBDifferComputer.java`	Comprehensive test suite for RDBDifferComputer covering various scenarios including version mapping and error handling
`TestCompositeDeltaDiffComputer.java`	Test suite for composite pattern with extensive mockConstruction usage to test fallback scenarios
`SnapshotDiffManager.java`	Refactored to delegate delta file computation to CompositeDeltaDiffComputer, removing 200+ lines of inline logic
`OmSnapshotManager.java`	Simplified constructor by removing direct differ dependency
`RocksDBCheckpointDiffer.java`	Modified `getSSTDiffListWithFullPath` to return `Map<Path, SstFileInfo>` instead of `List<String>`, removing link creation responsibility
`TestSstFileSetReader.java`	Updated to use `Path` instead of `String` for SST file references
`SstFileSetReader.java`	Updated constructor and internal methods to use `Path` instead of `String`
`RocksDiffUtils.java`	Removed unnecessary generic type parameter from `filterRelevantSstFiles` method signature
`TestSnapshotDiffManager.java`	Removed obsolete test methods for getDeltaFiles that are now handled by new computer classes
`findbugsExcludeFile.xml`	Added exclusion for test class to suppress false positive warnings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-19T21:31:58Z

...-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/RDBDifferComputer.java

+ * differing SST files as hard links in the configured delta directory.
+ *
+ * <p>This class uses {@link RocksDBCheckpointDiffer} to obtain the list of SST
+ * files that differ between a \"from\" and a \"to\" snapshot. It opens local


The escaped quote in the javadoc comment should be a regular quote. Change \"from\" and \"to\" to just "from" and "to" as javadoc doesn't require escaping quotes.

Suggested change

* files that differ between a \"from\" and a \"to\" snapshot. It opens local

* files that differ between a "from" and a "to" snapshot. It opens local

Copilot · 2025-11-19T21:31:59Z

...ager/src/test/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/TestRDBDifferComputer.java

+
+
+
+
+


[nitpick] Extra blank lines at the end of the file. Remove lines 532-535 to leave only a single blank line at the end of the file, following common Java style conventions.

Suggested change

Copilot · 2025-11-19T21:31:59Z

.../src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/FileLinkDeltaFileComputer.java

+ * responsible for computing delta files (a list of files if read completely would be able to completely
+ * compute all the key changes between two snapshots). Hard links to the
 * relevant source files in a specified delta directory, enabling a compact
 * representation of changes between snapshots.


Documentation is grammatically incomplete. Lines 52-55 form a sentence fragment. Consider rewording to: "responsible for computing delta files (a list of files that, if read completely, would enable computation of all key changes between two snapshots) and creating hard links to the relevant source files in a specified delta directory, enabling a compact representation of changes between snapshots."

Suggested change

* responsible for computing delta files (a list of files if read completely would be able to completely

* compute all the key changes between two snapshots). Hard links to the

* relevant source files in a specified delta directory, enabling a compact

* representation of changes between snapshots.

* responsible for computing delta files (a list of files that, if read completely, would enable computation of all key changes between two snapshots) and creating hard links to the relevant source files in a specified delta directory, enabling a compact representation of changes between snapshots.

Copilot · 2025-11-19T21:32:00Z

...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java

   * @return A list of SST files without extension.
   *         e.g. ["/path/to/sstBackupDir/000050.sst",
   *               "/path/to/sstBackupDir/000060.sst"]


The return description in the javadoc is outdated. The method now returns Optional<Map<Path, SstFileInfo>> but the documentation still says "A list of SST files without extension." Update this to accurately describe the return type as a Map of SST file paths to their corresponding SstFileInfo metadata.

Copilot · 2025-11-19T21:32:00Z

...src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/CompositeDeltaDiffComputer.java

+    }
+    // Workaround to handle deletes if native rocksDb tool for reading
+    // tombstone is not loaded.
+    // When performing non native diff, input files of from snapshot needs to be added.


Grammar error in comment. Change "input files of from snapshot needs to be added" to "input files from the from snapshot need to be added" (or "from the source snapshot need to be added" for clarity).

Suggested change

// When performing non native diff, input files of from snapshot needs to be added.

// When performing non native diff, input files from the 'from' snapshot need to be added.

Copilot · 2025-11-19T21:32:01Z

...test/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/TestCompositeDeltaDiffComputer.java

+    OmSnapshot fromSnap = org.mockito.Mockito.mock(OmSnapshot.class);
+    OMMetadataManager fromMetaMgr = org.mockito.Mockito.mock(OMMetadataManager.class);
+    RDBStore fromRdbStore = org.mockito.Mockito.mock(RDBStore.class);
+    when(fromSnap.getMetadataManager()).thenReturn(fromMetaMgr);
+    when(fromMetaMgr.getStore()).thenReturn(fromRdbStore);
+    when(fromRdbStore.getDbLocation()).thenReturn(fromDbPath.toFile());
+
+    @SuppressWarnings("unchecked")
+    UncheckedAutoCloseableSupplier<OmSnapshot> fromSnapSupplier = 
+        (UncheckedAutoCloseableSupplier<OmSnapshot>) org.mockito.Mockito.mock(UncheckedAutoCloseableSupplier.class);


Inconsistent use of mock() method. Lines 605-607 and 614 use the fully qualified org.mockito.Mockito.mock() instead of the already imported static method mock() (visible from the static imports at the top). Use mock(OmSnapshot.class) instead of org.mockito.Mockito.mock(OmSnapshot.class) for consistency with the rest of the test file.

Suggested change

OmSnapshot fromSnap = org.mockito.Mockito.mock(OmSnapshot.class);

OMMetadataManager fromMetaMgr = org.mockito.Mockito.mock(OMMetadataManager.class);

RDBStore fromRdbStore = org.mockito.Mockito.mock(RDBStore.class);

when(fromSnap.getMetadataManager()).thenReturn(fromMetaMgr);

when(fromMetaMgr.getStore()).thenReturn(fromRdbStore);

when(fromRdbStore.getDbLocation()).thenReturn(fromDbPath.toFile());

@SuppressWarnings("unchecked")

UncheckedAutoCloseableSupplier<OmSnapshot> fromSnapSupplier =

(UncheckedAutoCloseableSupplier<OmSnapshot>) org.mockito.Mockito.mock(UncheckedAutoCloseableSupplier.class);

OmSnapshot fromSnap = mock(OmSnapshot.class);

OMMetadataManager fromMetaMgr = mock(OMMetadataManager.class);

RDBStore fromRdbStore = mock(RDBStore.class);

when(fromSnap.getMetadataManager()).thenReturn(fromMetaMgr);

when(fromMetaMgr.getStore()).thenReturn(fromRdbStore);

when(fromRdbStore.getDbLocation()).thenReturn(fromDbPath.toFile());

@SuppressWarnings("unchecked")

UncheckedAutoCloseableSupplier<OmSnapshot> fromSnapSupplier =

(UncheckedAutoCloseableSupplier<OmSnapshot>) mock(UncheckedAutoCloseableSupplier.class);

Copilot · 2025-11-19T21:32:01Z

...src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/CompositeDeltaDiffComputer.java

+        Path fromSnapshotPath = fromSnapshot.get().getMetadataManager().getStore().getDbLocation()
+            .getAbsoluteFile().toPath();


Access of element annotated with VisibleForTesting found in production code.

Suggested change

Path fromSnapshotPath = fromSnapshot.get().getMetadataManager().getStore().getDbLocation()

.getAbsoluteFile().toPath();

Path fromSnapshotPath = fromSnapshot.get().getSnapshotPath();

Copilot · 2025-11-19T21:32:01Z

...src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/CompositeDeltaDiffComputer.java

+        Path fromSnapshotPath = fromSnapshot.get().getMetadataManager().getStore().getDbLocation()
+            .getAbsoluteFile().toPath();


Access of element annotated with VisibleForTesting found in production code.

Suggested change

Path fromSnapshotPath = fromSnapshot.get().getMetadataManager().getStore().getDbLocation()

.getAbsoluteFile().toPath();

Path fromSnapshotPath = fromSnapshot.get().getDbLocation().getAbsoluteFile().toPath();

Copilot · 2025-11-19T21:32:02Z

...-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/RDBDifferComputer.java

+      Path deltaDirPath, Consumer<SubStatus> activityReporter) throws IOException {
+    super(omSnapshotManager, activeMetadataManager, deltaDirPath, activityReporter);
+    this.differ = activeMetadataManager.getStore().getRocksDBCheckpointDiffer();


Access of element annotated with VisibleForTesting found in production code.

Suggested change

Path deltaDirPath, Consumer<SubStatus> activityReporter) throws IOException {

super(omSnapshotManager, activeMetadataManager, deltaDirPath, activityReporter);

this.differ = activeMetadataManager.getStore().getRocksDBCheckpointDiffer();

Path deltaDirPath, Consumer<SubStatus> activityReporter, RocksDBCheckpointDiffer differ) throws IOException {

super(omSnapshotManager, activeMetadataManager, deltaDirPath, activityReporter);

this.differ = differ;

jojochuang

lgtm. just code style suggestions. Once the CI comes back green feel free to merge and let's move on to the next one.

jojochuang · 2025-11-19T23:37:53Z

...one/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java


-  @VisibleForTesting
-  @SuppressWarnings("checkstyle:ParameterNumber")
-  Set<String> getDeltaFiles(OmSnapshot fromSnapshot,


removed because not used.

jojochuang · 2025-11-20T00:23:59Z

...-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/RDBDifferComputer.java

+  /**
+   * Convert from SnapshotInfo to DifferSnapshotInfo.
+   */
+  private static DifferSnapshotInfo getDSIFromSI(OMMetadataManager activeOmMetadataManager,


this is fine but semantically speaking I'd suggest to make it toDifferSnapshotInfo() in SnapshotInfo.

swamirishi · 2025-11-20T02:43:30Z

Will address the review comments in the next patch

swamirishi added 30 commits October 8, 2025 09:39

HDDS-13765. SnapshotLocalData yaml should also track snapshotId

6e241f6

Change-Id: Iba47aeb21663dfa407ab71339cef02c0d74b49f2

HDDS-13627. In memory Manager for Snapshot Local Data

a869500

Change-Id: Ifd2feca1fddb144e4955db025f0b15a2ab1f3bfe

HDDS-13627. In memory Manager for Snapshot Local Data

252d338

Change-Id: I34536ff06efb7d5a4942853f0fd83942ab398b5f

HDDS-13767. Refactor SnapshotLocalDataYaml related code into OmSnapsh…

4099bc6

…otLocalDataManager Change-Id: I34536ff06efb7d5a4942853f0fd83942ab398b5f

HDDS-13767. Fix pmd

e02670c

Change-Id: I32bcaf2a1fb290f1790c02872a0230cd65586636

HDDS-13627. Fix checkstyle

79580e9

Change-Id: I985170e38fb8beeb784048e85a08a4c79e1aec97

Merge remote-tracking branch 'apache/master' into HEAD

2a331ef

Change-Id: I33e6e6e825bf23c323ad7ed593d800a11720fa4f

Merge remote-tracking branch 'apache/master' into HEAD

c4f69e2

Change-Id: If30b2c766db82adde72145c8ecd3e590ef54cc2d

HDDS-13627. Add tests

afbc592

Change-Id: Id3f2c49050bc3476b9e0f5f51dacb6d9acc4c2f7

HDDS-13783. Implement locks for OmSnapshotLocalDataManager

70ac2c7

Change-Id: I432960725b4c6c55aa906b5780cc3027e41e10db

HDDS-13783. Implement locks for OmSnapshotLocalDataManager

b554cc7

Change-Id: I3c5514e5bbd251a2b5297d8f074cfde5c71fa543

HDDS-13783. Refactor inline variable

49eccfa

Change-Id: Ib5a9e6c91bdccba17820263c47eaf2c8400e930d

HDDS-13627. Refactor map data structure

51eda04

Change-Id: Ica36e0615c7bc6aa9b6a7f6fafafd0f830d4bafb

Merge remote-tracking branch 'origin/HDDS-13627' into HEAD

25f766c

Change-Id: I26b66f266bb7677e4b1078f5fcd9f2ce3a651a70 # Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java

HDDS-13783. Add more condition to upsert

96689fa

Change-Id: I1d93dbc048a42cc55ff1f8ffa420e52f967527b8

HDDS-13783. Add java doc comment

0674299

Change-Id: I34202928a7a367dd0a1e57219317ff34de352b78

HDDS-13783. Add java doc comment

5d9fc49

Change-Id: Iad6f26cb71ec921c51ee2d138745df1a2663533f

HDDS-13783. Implement full lock

2d88176

Change-Id: Ic5f7e249cfb9cb3973cbcd4abd36b22a6ff8f5aa

HDDS-13783. Refactor and move modify method into WritableOmSnapshotLo…

a3c4c69

…calDataProvider Change-Id: I3a004b4b435075a4348960aeed642e8da71e7e72

HDDS-13783. Make full lock non static

686d0c7

Change-Id: I06990bc9ab8fc7e1eb7bec255646a650bd8c35fe

HDDS-13783. Fix remove

491a54b

Change-Id: I4c6c61c83aa9fadab8ecef854b99dcc0a89a2208

HDDS-13627. Fix findbugs

5e69ee9

Change-Id: I0e476322372a302572f1fe79cbf2e874bfeac2ed

HDDS-13785. Remove orphan versions from SnapshotLocalData Yaml file

d36622a

Change-Id: I31004e0c95dad64411c6fe848501a82f2f773cba

HDDS-13785. Fix findbugs

ee213d1

Change-Id: Id317c8b56e8b25c122b68eaf96599b9690d08f79

HDDS-13627. Fix tests

a95604e

Change-Id: Ie5e5f3dab4324103e8855dd15619d7755f0422e6

HDDS-13627. remove checksum interface

5a90fcf

Change-Id: I55bd5c3ef7fc32910a9111328638de2edffcd541

HDDS-13627. Fix test failures

20d7d6a

Change-Id: I880997d3eebdf378f14c203c61c2d63b2d17552e

HDDS-13785. Set defrag flag on previous snapshotId update

ae655cb

Change-Id: I13ba8e2fd012a3c964d657e83496c93a4f55a3be

swamirishi added 5 commits November 14, 2025 07:20

Merge remote-tracking branch 'origin/HDDS-13867' into HEAD

84a0352

Change-Id: I47fca4c2ca1738b533992851fa54291cb109cc39

HDDS-13912. Address review comments

8890252

Change-Id: Id07b78b650ce58fcc71bbac478d085b139123b02

HDDS-13912. Fix interface

1067935

Change-Id: Iacf5dd1fd2013d6203ea7003645cb79433186519

HDDS-13912. Fix exception message

b086376

Change-Id: I22a212c84a3dbcd66a8e61a940d4df239b73133f

HDDS-13929. Modularise Snapshot Delta file computer (Efficient Diff)

4b1cf63

Change-Id: I4ab5c3d469b3729271ccccdf926699ec94b96e21

swamirishi requested review from jojochuang and smengcl November 17, 2025 14:41

swamirishi added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Nov 17, 2025

swamirishi added 3 commits November 17, 2025 09:59

HDDS-13929. Fix PMD

9b2d4f8

Change-Id: I857831bebe3a733d28998606cbf3f1b0676b2ba5

Merge remote-tracking branch 'origin/HDDS-13912' into HEAD

df34dd1

Change-Id: I4c023aeca7771fe6f65cb09f62a6253583c0d278 # Conflicts: # hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDiffUtils.java

swamirishi mentioned this pull request Nov 18, 2025

HDDS-13949. Move dbTxSequenceNumber from SnapshotInfo to LocalDataYaml file #9313

Merged

swamirishi added 3 commits November 18, 2025 07:30

HDDS-13929. Fix findbugs

1e04711

Change-Id: I6bedaf83ebfc65f46a7c3fd298fa7dc5f26d7fd1

Merge remote-tracking branch 'apache/master' into HEAD

ed8ee79

Change-Id: Ib313080b2ffa2f6e7545ae817f5e456cabc5dba7

Merge remote-tracking branch 'origin/HDDS-13912' into HEAD

ecb5084

Change-Id: I41308fd260de2e7ecdd8e8318e2155096212b687

swamirishi mentioned this pull request Nov 18, 2025

HDDS-13912. Modularise Snapshot Delta file computer (Full Diff) #9283

Merged

HDDS-13929. Fix javadoc

1201350

Change-Id: Ie464f0ed154e8911024dbe7802338e11a83f502a

jojochuang reviewed Nov 19, 2025

View reviewed changes

swamirishi added 3 commits November 19, 2025 12:20

HDDS-13929. Fix comment

42ca3d7

Change-Id: I6ae5c5897f9ca8580ba68b17ad77dffa35dfafb6

HDDS-13929. Change error log to warn

faa1380

Change-Id: Ib6089c9c7d8c787edd75721234d94d1ea0eb88c9

jojochuang requested a review from Copilot November 19, 2025 21:23

Copilot started reviewing on behalf of jojochuang November 19, 2025 21:23 View session

Copilot finished reviewing on behalf of jojochuang November 19, 2025 21:26

Copilot AI reviewed Nov 19, 2025

View reviewed changes

jojochuang marked this pull request as ready for review November 20, 2025 00:10

jojochuang reviewed Nov 20, 2025

View reviewed changes

swamirishi merged commit 4382cb3 into apache:master Nov 20, 2025
61 checks passed

	* files that differ between a \"from\" and a \"to\" snapshot. It opens local
	* files that differ between a "from" and a "to" snapshot. It opens local

	// When performing non native diff, input files of from snapshot needs to be added.
	// When performing non native diff, input files from the 'from' snapshot need to be added.

		Path fromSnapshotPath = fromSnapshot.get().getMetadataManager().getStore().getDbLocation()
		.getAbsoluteFile().toPath();

HDDS-13929. Modularise Snapshot Delta file computer (Efficient Diff) #9312

HDDS-13929. Modularise Snapshot Delta file computer (Efficient Diff) #9312

Uh oh!

Conversation

swamirishi commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Uh oh!

jojochuang Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

swamirishi Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jojochuang Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

swamirishi Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

jojochuang commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

jojochuang left a comment

Choose a reason for hiding this comment

Uh oh!

jojochuang Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

jojochuang Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

swamirishi commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

swamirishi commented Nov 17, 2025 •

edited

Loading

swamirishi Nov 19, 2025 •

edited

Loading