HDDS-13949. Move dbTxSequenceNumber from SnapshotInfo to LocalDataYaml file #9313

swamirishi · 2025-11-17T16:12:29Z

What changes were proposed in this pull request?

Currently dbTxSequenceNumber is computed in the validateAndUpdateCache method which can fetch wrong result and this needs to be computed in double buffer flush phase instead. Moreover this info should be persisted in the localData yaml file since OM rocksdb content should not have any divergence.
This won't cause any issue in snapshot diff output but the only consequence would be that the snapshot diff output can potentially return more delta entries in case of a pruned DAG and the snapshot diff could end up falling back to full diff.

This is built on #9312

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13949

How was this patch tested?

Added unit test

Change-Id: Iba47aeb21663dfa407ab71339cef02c0d74b49f2

Change-Id: Ifd2feca1fddb144e4955db025f0b15a2ab1f3bfe

Change-Id: I34536ff06efb7d5a4942853f0fd83942ab398b5f

…otLocalDataManager Change-Id: I34536ff06efb7d5a4942853f0fd83942ab398b5f

Change-Id: I32bcaf2a1fb290f1790c02872a0230cd65586636

Change-Id: I105a2e8178c0444d52de41b99801f4ceb6d57ffd # Conflicts: # hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/Checksum.java # hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/ObjectSerializer.java # hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/YamlSerializer.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotLocalDataYaml.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java # hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshotLocalDataYaml.java

Change-Id: I985170e38fb8beeb784048e85a08a4c79e1aec97

Change-Id: I33e6e6e825bf23c323ad7ed593d800a11720fa4f

Change-Id: If30b2c766db82adde72145c8ecd3e590ef54cc2d

Change-Id: Id3f2c49050bc3476b9e0f5f51dacb6d9acc4c2f7

Change-Id: I432960725b4c6c55aa906b5780cc3027e41e10db

Change-Id: I3c5514e5bbd251a2b5297d8f074cfde5c71fa543

Change-Id: Ib5a9e6c91bdccba17820263c47eaf2c8400e930d

Change-Id: Ica36e0615c7bc6aa9b6a7f6fafafd0f830d4bafb

Change-Id: I26b66f266bb7677e4b1078f5fcd9f2ce3a651a70 # Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java

Change-Id: I1d93dbc048a42cc55ff1f8ffa420e52f967527b8

Change-Id: I34202928a7a367dd0a1e57219317ff34de352b78

Change-Id: Iad6f26cb71ec921c51ee2d138745df1a2663533f

Change-Id: Ic5f7e249cfb9cb3973cbcd4abd36b22a6ff8f5aa

…calDataProvider Change-Id: I3a004b4b435075a4348960aeed642e8da71e7e72

Change-Id: I06990bc9ab8fc7e1eb7bec255646a650bd8c35fe

Change-Id: I4c6c61c83aa9fadab8ecef854b99dcc0a89a2208

Change-Id: I0e476322372a302572f1fe79cbf2e874bfeac2ed

Change-Id: I31004e0c95dad64411c6fe848501a82f2f773cba

Change-Id: Id317c8b56e8b25c122b68eaf96599b9690d08f79

Change-Id: I3849387d064e093634e69cdaf870d27c1934cda5 # Conflicts: # hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/ObjectSerializer.java # hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/YamlSerializer.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotLocalData.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotLocalDataYaml.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java

Change-Id: Ie5e5f3dab4324103e8855dd15619d7755f0422e6

Change-Id: I55bd5c3ef7fc32910a9111328638de2edffcd541

Change-Id: I880997d3eebdf378f14c203c61c2d63b2d17552e

Change-Id: I13ba8e2fd012a3c964d657e83496c93a4f55a3be

Change-Id: I63db69c634d96de05aaad865b467f1eee671440c

Change-Id: Ib313080b2ffa2f6e7545ae817f5e456cabc5dba7

Change-Id: I41308fd260de2e7ecdd8e8318e2155096212b687

Change-Id: Ie607809e088aee642940f72fdd12a258a06cc96d # Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java

swamirishi · 2025-11-18T14:04:32Z

Having local YAML for every snapshot have below concern,

for any update of yaml, need ensure, update done in new file, existing to be moved to backup and rename new one, delete backup.

Any failure in above need a recovery during startup

Reading 64k yaml file is slower for doing verification.

A scheduler to verify the consistency of file or during startup

My suggestion,

Can have another common local-rocksdb or snapshot-db for this, which handle all above implicitly. So this do not need scan of each file and its transaction safe implicitly present.

related to redability,

value can be yaml content OR ozone ldb can support same.

I don't think we need to be worried about the scale aspect here. Reading one yaml file would be order of 100 microseconds, so even if we have to read 64000 snapshots we are talking about few seconds at best.
We can create a backburner jira for this and move this into a rocksdb later on. Once we are done with the defrag implementation.
Our rational behind having a yaml file was to be able to debug things easily when things go wrong since these files are human readable.

Change-Id: Ie464f0ed154e8911024dbe7802338e11a83f502a

Change-Id: I8abb7a9db2e595f0cf2a0d257cb38caaacec6e1f

Change-Id: I09301ff17cf3c8abab5785d25336c7633f8ac293

Change-Id: I3e885ef24c95280ea0acccaf44787bd295aedbe4 # Conflicts: # hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/IOUtils.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/DeltaFileComputer.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/FileLinkDeltaFileComputer.java

Change-Id: I6ae5c5897f9ca8580ba68b17ad77dffa35dfafb6

Change-Id: Ib6089c9c7d8c787edd75721234d94d1ea0eb88c9

Change-Id: Idbf1d64b72ff4a8c80b2da8515639e430cef895c

jojochuang

Looks straightforward. Please rebase after merging #9312

Change-Id: Ie968331ba23db3ae33ca421599a75ead35076d48 # Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/RDBDifferComputer.java # hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/TestCompositeDeltaDiffComputer.java # hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/TestRDBDifferComputer.java

Change-Id: I227cf7471e5235204926fb5f48c754516222fc30

jojochuang

New client won't work properly with an old OM because dbTxSequenceNumber will not be set by client. Looks like this is only going to affect snapshot create request .

smengcl · 2025-11-20T11:33:02Z

Should this be marked ready?

smengcl · 2025-11-20T12:49:13Z

hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto

  optional string snapshotPath = 10;
  optional string checkpointDir = 11 [deprecated = true];
-  optional int64 dbTxSequenceNumber = 12;
+  optional int64 dbTxSequenceNumber = 12 [deprecated = true];


It might be safe to just remove this field later, so that when SnapshotInfo is serialized again this field will be ignored while maintaining compatibility, as long as we don't use field number 12 ever again for this message.

Copilot

Pull Request Overview

This PR moves the dbTxSequenceNumber field from SnapshotInfo to OmSnapshotLocalData (persisted in YAML files), addressing an architectural issue where this value was being computed incorrectly during the validateAndUpdateCache phase. The field now gets computed during the double buffer flush phase from SST file metadata, ensuring consistency and preventing potential issues with pruned DAGs causing incorrect snapshot diff outputs.

Key changes:

Removed dbTxSequenceNumber from SnapshotInfo class and deprecated it in the protobuf schema
Added dbTxSequenceNumber to OmSnapshotLocalData with computation from SST file largestSeqno values
Updated all usages to fetch dbTxSequenceNumber from local data instead of snapshot info

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/SnapshotInfo.java`	Removed `dbTxSequenceNumber` field, getter, setter, and builder methods from SnapshotInfo class
`hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto`	Marked `dbTxSequenceNumber` field as deprecated in SnapshotInfo protobuf message
`hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotLocalData.java`	Added `dbTxSequenceNumber` field with getter and copy constructor support
`hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotLocalDataYaml.java`	Added YAML serialization/deserialization support for `dbTxSequenceNumber`
`hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java`	Added `OM_SLD_DB_TXN_SEQ_NUMBER` constant for YAML field name
`hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java`	Implemented computation of `dbTxSequenceNumber` from SST file metadata during snapshot creation
`hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java`	Removed incorrect computation of `dbTxSequenceNumber` from validateAndUpdateCache
`hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/RDBDifferComputer.java`	Updated to fetch `dbTxSequenceNumber` from `OmSnapshotLocalData` instead of `SnapshotInfo`
`hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java`	Fixed documentation comment for return type
Test files	Updated all tests to remove `dbTxSequenceNumber` from mock SnapshotInfo objects and added validation for the new field in OmSnapshotLocalData

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-20T12:57:24Z

...ager/src/test/java/org/apache/hadoop/ozone/om/snapshot/diff/delta/TestRDBDifferComputer.java

@@ -363,7 +363,7 @@ public void testComputeDeltaFilesWithVersionMapping() throws IOException {
   * Tests that getDSIFromSI throws exception when no versions found.


The comment still references the old method name 'getDSIFromSI'. It should be updated to 'toDifferSnapshotInfo' to match the renamed method on line 366.

Suggested change

* Tests that getDSIFromSI throws exception when no versions found.

* Tests that toDifferSnapshotInfo throws exception when no versions found.

Copilot · 2025-11-20T12:57:24Z

...op-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotLocalDataYaml.java

        final String prevSnapIdStr = (String) nodes.get(OzoneConsts.OM_SLD_PREV_SNAP_ID);
        UUID prevSnapId = prevSnapIdStr != null ? UUID.fromString(prevSnapIdStr) : null;
        final String purgeTxInfoStr = (String) nodes.get(OzoneConsts.OM_SLD_TXN_INFO);
+        final long dbTxnSeqNumber = ((Number)nodes.get(OzoneConsts.OM_SLD_DB_TXN_SEQ_NUMBER)).longValue();


Potential NullPointerException when reading existing YAML files that don't have the 'dbTxSequenceNumber' field. The code assumes the field exists and directly calls .longValue() without null-checking. Consider using getOrDefault() with a default value of 0L, similar to how 'lastDefragTime' is handled on lines 188-195.

Suggested change

final long dbTxnSeqNumber = ((Number)nodes.get(OzoneConsts.OM_SLD_DB_TXN_SEQ_NUMBER)).longValue();

Object dbTxnSeqNumberObj = nodes.getOrDefault(OzoneConsts.OM_SLD_DB_TXN_SEQ_NUMBER, 0L);

long dbTxnSeqNumber;

if (dbTxnSeqNumberObj instanceof Number) {

dbTxnSeqNumber = ((Number) dbTxnSeqNumberObj).longValue();

} else {

throw new IllegalArgumentException("Invalid type for dbTxSequenceNumber: " +

dbTxnSeqNumberObj.getClass().getName() + ". Expected Number type.");

}

this should never happen

Copilot · 2025-11-20T12:57:24Z

hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotLocalData.java

  // Stores the transactionInfo corresponding to OM when the snaphot is purged.
  private TransactionInfo transactionInfo;

+  // Stores the rocksDB's transaction sequence number at the time of snapshot creation.'


Typo in comment: trailing apostrophe should be removed. The period at the end is sufficient.

Suggested change

// Stores the rocksDB's transaction sequence number at the time of snapshot creation.'

// Stores the rocksDB's transaction sequence number at the time of snapshot creation.

smengcl · 2025-11-20T12:57:26Z

...ne-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java

+                 () -> {
+                   List<LiveFileMetaData> lfms = getLiveSSTFilesForCFs(snapshotStore.getDb().getManagedRocksDb(),
+                       COLUMN_FAMILIES_TO_TRACK_IN_SNAPSHOT);
+                   long dbTxnSeqNumber = lfms.stream().mapToLong(LiveFileMetaData::largestSeqno).max().orElse(0L);


Do we still want to fall back to the dbTxSeqNumber stored in SnapshotInfo proto?

No this should be ok. We are basically talking about acquiring an empty rocksdb if there are no sst files for the tables.

smengcl

Pls check Copilot's comment
Pls double check for any upgrade concerns (e.g. the one noted by Wei-Chiu above)
I have a few minor comments inline

Other than that, I am good with this. Thanks @swamirishi

swamirishi · 2025-11-20T17:03:08Z

New client won't work properly with an old OM because dbTxSequenceNumber will not be set by client. Looks like this is only going to affect snapshot create request .

I don't think we expose the dbTxn number. So this should be ok. The value captured earilier was also smaller than the snapshot's value so it should be ok if we start showing a 0. The worst that would happen is the DAG traversal will go all the way to the top. We should never expose this value to clients ever since this is specific to one OM and the value returned to clients could be different depending on the OM serviing the request.

Change-Id: If0400fa3ac799e8487888dd1149914fe093a5e6f

swamirishi · 2025-11-20T20:14:42Z

Thank you @jojochuang and @smengcl for reviewing the patch

swamirishi added 30 commits October 8, 2025 09:39

HDDS-13765. SnapshotLocalData yaml should also track snapshotId

6e241f6

Change-Id: Iba47aeb21663dfa407ab71339cef02c0d74b49f2

HDDS-13627. In memory Manager for Snapshot Local Data

a869500

Change-Id: Ifd2feca1fddb144e4955db025f0b15a2ab1f3bfe

HDDS-13627. In memory Manager for Snapshot Local Data

252d338

Change-Id: I34536ff06efb7d5a4942853f0fd83942ab398b5f

HDDS-13767. Refactor SnapshotLocalDataYaml related code into OmSnapsh…

4099bc6

…otLocalDataManager Change-Id: I34536ff06efb7d5a4942853f0fd83942ab398b5f

HDDS-13767. Fix pmd

e02670c

Change-Id: I32bcaf2a1fb290f1790c02872a0230cd65586636

HDDS-13627. Fix checkstyle

79580e9

Change-Id: I985170e38fb8beeb784048e85a08a4c79e1aec97

Merge remote-tracking branch 'apache/master' into HEAD

2a331ef

Change-Id: I33e6e6e825bf23c323ad7ed593d800a11720fa4f

Merge remote-tracking branch 'apache/master' into HEAD

c4f69e2

Change-Id: If30b2c766db82adde72145c8ecd3e590ef54cc2d

HDDS-13627. Add tests

afbc592

Change-Id: Id3f2c49050bc3476b9e0f5f51dacb6d9acc4c2f7

HDDS-13783. Implement locks for OmSnapshotLocalDataManager

70ac2c7

Change-Id: I432960725b4c6c55aa906b5780cc3027e41e10db

HDDS-13783. Implement locks for OmSnapshotLocalDataManager

b554cc7

Change-Id: I3c5514e5bbd251a2b5297d8f074cfde5c71fa543

HDDS-13783. Refactor inline variable

49eccfa

Change-Id: Ib5a9e6c91bdccba17820263c47eaf2c8400e930d

HDDS-13627. Refactor map data structure

51eda04

Change-Id: Ica36e0615c7bc6aa9b6a7f6fafafd0f830d4bafb

Merge remote-tracking branch 'origin/HDDS-13627' into HEAD

25f766c

Change-Id: I26b66f266bb7677e4b1078f5fcd9f2ce3a651a70 # Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java

HDDS-13783. Add more condition to upsert

96689fa

Change-Id: I1d93dbc048a42cc55ff1f8ffa420e52f967527b8

HDDS-13783. Add java doc comment

0674299

Change-Id: I34202928a7a367dd0a1e57219317ff34de352b78

HDDS-13783. Add java doc comment

5d9fc49

Change-Id: Iad6f26cb71ec921c51ee2d138745df1a2663533f

HDDS-13783. Implement full lock

2d88176

Change-Id: Ic5f7e249cfb9cb3973cbcd4abd36b22a6ff8f5aa

HDDS-13783. Refactor and move modify method into WritableOmSnapshotLo…

a3c4c69

…calDataProvider Change-Id: I3a004b4b435075a4348960aeed642e8da71e7e72

HDDS-13783. Make full lock non static

686d0c7

Change-Id: I06990bc9ab8fc7e1eb7bec255646a650bd8c35fe

HDDS-13783. Fix remove

491a54b

Change-Id: I4c6c61c83aa9fadab8ecef854b99dcc0a89a2208

HDDS-13627. Fix findbugs

5e69ee9

Change-Id: I0e476322372a302572f1fe79cbf2e874bfeac2ed

HDDS-13785. Remove orphan versions from SnapshotLocalData Yaml file

d36622a

Change-Id: I31004e0c95dad64411c6fe848501a82f2f773cba

HDDS-13785. Fix findbugs

ee213d1

Change-Id: Id317c8b56e8b25c122b68eaf96599b9690d08f79

HDDS-13627. Fix tests

a95604e

Change-Id: Ie5e5f3dab4324103e8855dd15619d7755f0422e6

HDDS-13627. remove checksum interface

5a90fcf

Change-Id: I55bd5c3ef7fc32910a9111328638de2edffcd541

HDDS-13627. Fix test failures

20d7d6a

Change-Id: I880997d3eebdf378f14c203c61c2d63b2d17552e

HDDS-13785. Set defrag flag on previous snapshotId update

ae655cb

Change-Id: I13ba8e2fd012a3c964d657e83496c93a4f55a3be

swamirishi added 4 commits November 18, 2025 07:43

HDDS-13949. Fix findbugs

6fc9a2c

Change-Id: I63db69c634d96de05aaad865b467f1eee671440c

Merge remote-tracking branch 'apache/master' into HEAD

ed8ee79

Change-Id: Ib313080b2ffa2f6e7545ae817f5e456cabc5dba7

Merge remote-tracking branch 'origin/HDDS-13912' into HEAD

ecb5084

Change-Id: I41308fd260de2e7ecdd8e8318e2155096212b687

Merge remote-tracking branch 'origin/HDDS-13929' into HEAD

632c009

Change-Id: Ie607809e088aee642940f72fdd12a258a06cc96d # Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java

swamirishi added 2 commits November 19, 2025 00:45

HDDS-13929. Fix javadoc

1201350

Change-Id: Ie464f0ed154e8911024dbe7802338e11a83f502a

Merge remote-tracking branch 'origin/HDDS-13929' into HEAD

505d6c5

Change-Id: I8abb7a9db2e595f0cf2a0d257cb38caaacec6e1f

swamirishi force-pushed the HDDS-13949 branch from 2f5c5c7 to 505d6c5 Compare November 19, 2025 05:49

swamirishi added 5 commits November 19, 2025 08:41

HDDS-13949. Add back snapshotPath init removed by mistake

edf0213

Change-Id: I09301ff17cf3c8abab5785d25336c7633f8ac293

HDDS-13929. Fix comment

42ca3d7

Change-Id: I6ae5c5897f9ca8580ba68b17ad77dffa35dfafb6

HDDS-13929. Change error log to warn

faa1380

Change-Id: Ib6089c9c7d8c787edd75721234d94d1ea0eb88c9

Merge remote-tracking branch 'origin/HDDS-13929' into HEAD

d3f3836

Change-Id: Idbf1d64b72ff4a8c80b2da8515639e430cef895c

jojochuang reviewed Nov 20, 2025

View reviewed changes

swamirishi added 2 commits November 19, 2025 21:47

HDDS-13949. Address review comments from HDDS-13929

4a36e98

Change-Id: I227cf7471e5235204926fb5f48c754516222fc30

jojochuang reviewed Nov 20, 2025

View reviewed changes

smengcl reviewed Nov 20, 2025

View reviewed changes

smengcl requested a review from Copilot November 20, 2025 12:49

Copilot started reviewing on behalf of smengcl November 20, 2025 12:50 View session

Copilot finished reviewing on behalf of smengcl November 20, 2025 12:54

Copilot AI reviewed Nov 20, 2025

View reviewed changes

smengcl reviewed Nov 20, 2025

View reviewed changes

smengcl approved these changes Nov 20, 2025

View reviewed changes

HDDS-13949. Address review comments

668ca9d

Change-Id: If0400fa3ac799e8487888dd1149914fe093a5e6f

swamirishi marked this pull request as ready for review November 20, 2025 17:04

swamirishi merged commit 0381646 into apache:master Nov 20, 2025
129 of 137 checks passed

		@@ -363,7 +363,7 @@ public void testComputeDeltaFilesWithVersionMapping() throws IOException {
		* Tests that getDSIFromSI throws exception when no versions found.

	* Tests that getDSIFromSI throws exception when no versions found.
	* Tests that toDifferSnapshotInfo throws exception when no versions found.

-        final long dbTxnSeqNumber = ((Number)nodes.get(OzoneConsts.OM_SLD_DB_TXN_SEQ_NUMBER)).longValue();
+        Object dbTxnSeqNumberObj = nodes.getOrDefault(OzoneConsts.OM_SLD_DB_TXN_SEQ_NUMBER, 0L);
+        long dbTxnSeqNumber;
+        if (dbTxnSeqNumberObj instanceof Number) {
+          dbTxnSeqNumber = ((Number) dbTxnSeqNumberObj).longValue();
+        } else {
+          throw new IllegalArgumentException("Invalid type for dbTxSequenceNumber: " +
+              dbTxnSeqNumberObj.getClass().getName() + ". Expected Number type.");
+        }

	// Stores the rocksDB's transaction sequence number at the time of snapshot creation.'
	// Stores the rocksDB's transaction sequence number at the time of snapshot creation.

HDDS-13949. Move dbTxSequenceNumber from SnapshotInfo to LocalDataYaml file #9313

HDDS-13949. Move dbTxSequenceNumber from SnapshotInfo to LocalDataYaml file #9313

Uh oh!

Conversation

swamirishi commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Uh oh!

swamirishi commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jojochuang left a comment

Choose a reason for hiding this comment

Uh oh!

jojochuang left a comment

Choose a reason for hiding this comment

Uh oh!

smengcl commented Nov 20, 2025

Uh oh!

smengcl Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

swamirishi Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

smengcl Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

swamirishi Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

smengcl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swamirishi commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swamirishi commented Nov 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

swamirishi commented Nov 17, 2025 •

edited

Loading

swamirishi commented Nov 18, 2025 •

edited

Loading

smengcl left a comment •

edited

Loading

swamirishi commented Nov 20, 2025 •

edited

Loading