This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-477: Add clang-format / clang-tidy checks to toolchain #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1, lots of changes but no problems ;) |
| include_directories(SYSTEM ${ZLIB_INCLUDE_DIRS}) | ||
| add_library(zlibstatic STATIC IMPORTED) | ||
| set_target_properties(zlibstatic PROPERTIES IMPORTED_LOCATION ${ZLIB_LIBRARIES}) | ||
| set_target_properties(zlibstatic PROPERTIES IMPORTED_LOCATION ${ZLIB_STATIC_LIB}) |
Member
Author
There was a problem hiding this comment.
Zlib was being dynamically linked (and there is a valgrind warning on Ubuntu 12.04) so this fixes that
Member
Author
|
+1, thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adapted @emkornfield's work from ARROW-71 (apache/arrow@5d12999). It's a large diff due to the first reformatting of the codebase. Per travis-ci/apt-source-safelist#199 we can switch Travis back to Ubuntu 14.04 and maybe upgrade to LLVM 3.8 at some point in the future.