PARQUET-2022: ZstdDecompressorStream should close zstdInputStream#889
Merged
gszadovszky merged 1 commit intoapache:masterfrom Apr 19, 2021
dongjoon-hyun:PARQUET-2022
Merged
PARQUET-2022: ZstdDecompressorStream should close zstdInputStream#889gszadovszky merged 1 commit intoapache:masterfrom dongjoon-hyun:PARQUET-2022
zstdInputStream#889gszadovszky merged 1 commit intoapache:masterfrom
dongjoon-hyun:PARQUET-2022
Conversation
`ZstdDecompressorStream` should close its resource because `CompressionInputStream.close` closes only the inner stream.
```
public class ZstdDecompressorStream extends CompressionInputStream {
private ZstdInputStream zstdInputStream;
public ZstdDecompressorStream(InputStream stream) throws IOException {
super(stream);
zstdInputStream = new ZstdInputStream(stream);
}
}
```
Fokko
approved these changes
Apr 11, 2021
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing this @dongjoon-hyun
Member
Author
|
Thank you, @Fokko ! |
Member
Author
|
Could you review this, @gszadovszky ? |
Member
Author
|
Could you review this, @ggershinsky ? |
Contributor
|
will do |
Member
Author
|
Thank you so much, @ggershinsky ! |
Member
Author
|
Thank you for your review and approval, @ggershinsky ! |
Member
Author
|
Gentle ping, @gszadovszky . |
gszadovszky
approved these changes
Apr 19, 2021
Member
Author
|
Thank you, @Fokko , @ggershinsky , @gszadovszky ! |
Contributor
|
Thanks @dongjoon-hyun for working on this! cc @vectorijk |
Member
Author
|
Thank you, @shangxinli . |
elikkatz
added a commit
to TheWeatherCompany/parquet-mr
that referenced
this pull request
Jun 2, 2021
* 'master' of https://github.com/apache/parquet-mr: (222 commits) PARQUET-2052: Integer overflow when writing huge binary using dictionary encoding (apache#910) PARQUET-2041: Add zstd to `parquet.compression` description of ParquetOutputFormat Javadoc (apache#899) PARQUET-2050: Expose repetition & definition level from ColumnIO (apache#908) PARQUET-1761: Lower Logging Level in ParquetOutputFormat (apache#745) PARQUET-2046: Upgrade Apache POM to 23 (apache#904) PARQUET-2048: Deprecate BaseRecordReader (apache#906) PARQUET-1922: Deprecate IOExceptionUtils (apache#825) PARQUET-2037: Write INT96 with parquet-avro (apache#901) PARQUET-2044: Enable ZSTD buffer pool by default (apache#903) PARQUET-2038: Upgrade Jackson version used in parquet encryption. (apache#898) Revert "[WIP] Refactor GroupReadSupport to unuse deprecated api (apache#894)" PARQUET-2027: Fix calculating directory offset for merge (apache#896) [WIP] Refactor GroupReadSupport to unuse deprecated api (apache#894) PARQUET-2030: Expose page size row check configurations to ParquetWriter.Builder (apache#895) PARQUET-2031: Upgrade to parquet-format 2.9.0 (apache#897) PARQUET-1448: Review of ParquetFileReader (apache#892) PARQUET-2020: Remove deprecated modules (apache#888) PARQUET-2025: Update Snappy version to 1.1.8.3 (apache#893) PARQUET-2022: ZstdDecompressorStream should close `zstdInputStream` (apache#889) PARQUET-1982: Random access to row groups in ParquetFileReader (apache#871) ... # Conflicts: # parquet-column/src/main/java/org/apache/parquet/example/data/simple/SimpleGroup.java # parquet-hadoop/pom.xml # parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java # parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
shangxinli
pushed a commit
to shangxinli/parquet-mr
that referenced
this pull request
Sep 9, 2021
4 tasks
shangxinli
pushed a commit
that referenced
this pull request
Sep 9, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZstdDecompressorStreamshould close its resource becauseCompressionInputStream.closecloses only the inner stream.Make sure you have checked all steps below.
Jira
Tests
Use revised test case.
Commits
Documentation