PARQUET-2050: Expose repetition & definition level from ColumnIO#908
PARQUET-2050: Expose repetition & definition level from ColumnIO#908gszadovszky merged 3 commits intoapache:masterfrom
Conversation
|
For rationale, please check the JIRA https://issues.apache.org/jira/browse/PARQUET-2050. Not sure where should I put those in the PR description. |
|
@shangxinli @ggershinsky @gszadovszky could you review this? Thanks! |
|
@gszadovszky Is there any concern from you? |
gszadovszky
left a comment
There was a problem hiding this comment.
I am fine having these methods public if it is required for our users. Meanwhile, since it is public, it would be great having the proper javadoc comments for them.
|
Thanks for the review @gszadovszky . Added. |
|
LGTM. After fixing the checks failure, we can merge. |
|
Thanks @shangxinli and @gszadovszky . Do you know how to see the details for the check failures? I opened the link and it just shows "This check failed". |
|
Let me trigger the CI again to find out why. |
|
I don't know why we had such failures but they were not only for this PR. As they are passing now I'm merging this PR. |
* 'master' of https://github.com/apache/parquet-mr: (222 commits) PARQUET-2052: Integer overflow when writing huge binary using dictionary encoding (apache#910) PARQUET-2041: Add zstd to `parquet.compression` description of ParquetOutputFormat Javadoc (apache#899) PARQUET-2050: Expose repetition & definition level from ColumnIO (apache#908) PARQUET-1761: Lower Logging Level in ParquetOutputFormat (apache#745) PARQUET-2046: Upgrade Apache POM to 23 (apache#904) PARQUET-2048: Deprecate BaseRecordReader (apache#906) PARQUET-1922: Deprecate IOExceptionUtils (apache#825) PARQUET-2037: Write INT96 with parquet-avro (apache#901) PARQUET-2044: Enable ZSTD buffer pool by default (apache#903) PARQUET-2038: Upgrade Jackson version used in parquet encryption. (apache#898) Revert "[WIP] Refactor GroupReadSupport to unuse deprecated api (apache#894)" PARQUET-2027: Fix calculating directory offset for merge (apache#896) [WIP] Refactor GroupReadSupport to unuse deprecated api (apache#894) PARQUET-2030: Expose page size row check configurations to ParquetWriter.Builder (apache#895) PARQUET-2031: Upgrade to parquet-format 2.9.0 (apache#897) PARQUET-1448: Review of ParquetFileReader (apache#892) PARQUET-2020: Remove deprecated modules (apache#888) PARQUET-2025: Update Snappy version to 1.1.8.3 (apache#893) PARQUET-2022: ZstdDecompressorStream should close `zstdInputStream` (apache#889) PARQUET-1982: Random access to row groups in ParquetFileReader (apache#871) ... # Conflicts: # parquet-column/src/main/java/org/apache/parquet/example/data/simple/SimpleGroup.java # parquet-hadoop/pom.xml # parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java # parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation