Skip to content

PARQUET-2064: Make Range public accessible in RowRanges #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gszadovszky merged 2 commits into from
Aug 16, 2021
Merged

PARQUET-2064: Make Range public accessible in RowRanges #921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e38693
PARQUET-2064: Make Range public accessible in RowRanges
shangxinli Aug 9, 2021
a83daf2
Address comments
shangxinli Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions parquet-column/src/main/java/org/apache/parquet/internal/filter2/columnindex/RowRanges.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
* @see ColumnIndexFilter#calculateRowRanges(Filter, ColumnIndexStore, Set, long)
*/
public class RowRanges {
private static class Range {
// Make it public because some uppler layer application need to access it
public static class Range {

// Returns the union of the two ranges or null if there are elements between them.
private static Range union(Range left, Range right) {
Expand All @@ -63,8 +64,8 @@ private static Range intersection(Range left, Range right) {
return null;
}

final long from;
final long to;
public final long from;
public final long to;

// Creates a range of [from, to] (from and to are inclusive; empty ranges are not valid)
Range(long from, long to) {
Expand Down Expand Up @@ -299,6 +300,10 @@ public boolean isOverlapping(long from, long to) {
(r1, r2) -> r1.isBefore(r2) ? -1 : r1.isAfter(r2) ? 1 : 0) >= 0;
}

public List<Range> getRanges() {
return Collections.unmodifiableList(ranges);
}

@Override
public String toString() {
return ranges.toString();
Expand Down