[Tests] Enable test retries for integration tests, shade tests and backwards compat tests #10191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
changed the title
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Apr 13, 2021
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Apr 13, 2021
- some relevant code was missing from PR apache#10191
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Apr 15, 2021
- some relevant code was missing from PR apache#10191
merlimat
pushed a commit
that referenced
this pull request
Apr 16, 2021
- some relevant code was missing from PR #10191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some integration tests fail often and retrying all integration tests is slow.
Modifications
Enable the test retries at TestNG level also for integration tests.
When a Pulsar broker url is passed as a parameter to a test method, it's necessary to use a
Supplier<String>parameter so that the value gets evaluated again for test retries.