Fix test retries for shade and backwards compat tests #10207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Apr 13, 2021
- some relevant code was missing from PR apache#10191
lhotari
force-pushed
the
lh-fix-inttest-retries
branch
from
d822c8f to
a836c0a
Compare
merlimat
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test retries were added in PR #10191 for integration tests, shade tests and backwards compat tests. There was some relevant code missing for handling retries in shade and backwards compat tests.
Modifications
TestRetrySupport.incrementSetupNumber()andTestRetrySupport.markCurrentSetupNumberCleaned()calls to tests so that the state tracking in org.apache.pulsar.tests.TestRetrySupport will be able to detect retries and callcleanupandsetupbefore a retry.