Skip to content

Conversation

@codelipenghui
Copy link
Contributor

We have change the nar package name in #9808 which will broken the website download link,
The reported issue is https://issues.apache.org/jira/browse/PULSAR-16

We have change the nar package name in apache#9808 which will broken the website download link,
The reported issue is https://issues.apache.org/jira/browse/PULSAR-16
@codelipenghui codelipenghui added this to the 2.9.0 milestone Jun 18, 2021
@codelipenghui codelipenghui self-assigned this Jun 18, 2021
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that this won't break something downstream for the users of this module.
probably it is not a problem

@dlg99 would you mind to take a look ?
you talked about this module at PulsarSummit

@dlg99
Copy link
Contributor

dlg99 commented Jun 18, 2021

I don't think it will break anything, but it might be confusing (as in: tracking what builds the file) given existing pulsar/pulsar-io/kafka-connect-adaptor module.
It should be ok to simply update the website.
Either way is good with me.

@eolivelli
Copy link
Contributor

Integration tests failed.
@codelipenghui PTAL

@dlg99
Copy link
Contributor

dlg99 commented Jun 18, 2021

@codelipenghui integration tests failed with

Error:  Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.3.0:single (distro-assembly) on project pulsar-io-distribution: Failed to create assembly: Error adding file to archive: /home/runner/work/pulsar/pulsar/distribution/io/./../../pulsar-io/kafka-connect-adaptor-nar/target/pulsar-io-kafka-connect-adaptor-nar-2.9.0-SNAPSHOT.nar -> [Help 1]

probably need to update

<file><source>${basedir}/../../pulsar-io/kafka-connect-adaptor-nar/target/pulsar-io-kafka-connect-adaptor-nar-${project.version}.nar</source></file>

@codelipenghui
Copy link
Contributor Author

Thanks @dlg99 @eolivelli. Will fix the tests soon.

@codelipenghui codelipenghui requested a review from eolivelli June 21, 2021 02:37
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit 16667d8 into apache:master Jun 21, 2021
@codelipenghui codelipenghui deleted the penghui/fix-kafka-adaptor-nar-name branch June 21, 2021 07:32
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
…he#10976)

* Change the nar package name for pulsar-io-kafka-connect-adaptor

We have change the nar package name in apache#9808 which will broken the website download link,
The reported issue is https://issues.apache.org/jira/browse/PULSAR-16

* Fix tests.
codelipenghui added a commit that referenced this pull request Jun 25, 2021
* Change the nar package name for pulsar-io-kafka-connect-adaptor

We have change the nar package name in #9808 which will broken the website download link,
The reported issue is https://issues.apache.org/jira/browse/PULSAR-16

* Fix tests.

(cherry picked from commit 16667d8)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jun 25, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…he#10976)

* Change the nar package name for pulsar-io-kafka-connect-adaptor

We have change the nar package name in apache#9808 which will broken the website download link,
The reported issue is https://issues.apache.org/jira/browse/PULSAR-16

* Fix tests.
@codelipenghui codelipenghui restored the penghui/fix-kafka-adaptor-nar-name branch May 17, 2022 01:19
@codelipenghui codelipenghui deleted the penghui/fix-kafka-adaptor-nar-name branch May 17, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants