Split pulsar-io-kafka-connect-adaptor into a jar and nar modules #9808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Mar 4, 2021
zymap
approved these changes
Mar 5, 2021
mlyahmed
pushed a commit
to mlyahmed/pulsar
that referenced
this pull request
Mar 5, 2021
1 task
codelipenghui
added a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 18, 2021
We have change the nar package name in apache#9808 which will broken the website download link, The reported issue is https://issues.apache.org/jira/browse/PULSAR-16
eolivelli
pushed a commit
that referenced
this pull request
Jun 21, 2021
* Change the nar package name for pulsar-io-kafka-connect-adaptor We have change the nar package name in #9808 which will broken the website download link, The reported issue is https://issues.apache.org/jira/browse/PULSAR-16 * Fix tests.
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…he#10976) * Change the nar package name for pulsar-io-kafka-connect-adaptor We have change the nar package name in apache#9808 which will broken the website download link, The reported issue is https://issues.apache.org/jira/browse/PULSAR-16 * Fix tests.
codelipenghui
added a commit
that referenced
this pull request
Jun 25, 2021
* Change the nar package name for pulsar-io-kafka-connect-adaptor We have change the nar package name in #9808 which will broken the website download link, The reported issue is https://issues.apache.org/jira/browse/PULSAR-16 * Fix tests. (cherry picked from commit 16667d8)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…he#10976) * Change the nar package name for pulsar-io-kafka-connect-adaptor We have change the nar package name in apache#9808 which will broken the website download link, The reported issue is https://issues.apache.org/jira/browse/PULSAR-16 * Fix tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
pulsar-io-kafka-connect-adaptormodule is being used both as a standalone connector as well as an adaptor for debezium connectors.Since we're building a NAR for that though, the debezium connectors are also including the full NAR inside their own NAR. That results in ~80MB of NAR included 3 times and not being used all.
Instead, we should split the adapted into a simple dependency and then build the nar, so the debezium connectors will be much smaller.