Skip to content

Conversation

@dlg99
Copy link
Contributor

@dlg99 dlg99 commented Jul 2, 2021

Fixes #8502

Motivation

Upgrade Debezium to a newer version

Modifications

Upgraded Deebzium to v.1.5.4 (latest built with Java 8, v.1.6.x built with Java 11)
Upgraded kafka-client to 2.7 (version debezium tested with)
Scala-lib to 2.13.6 (for kafka-client)

Dealt with API changes, tests etc.

PR is on top of #11154 to have Debezium integration tests on CI.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is already covered by existing tests, such as org.apache.pulsar.io.debezium.PulsarDatabaseHistoryTest, org.apache.pulsar.tests.integration.io.sources.debezium.PulsarDebeziumSourcesTest .

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): yes
  • Anything that affects deployment: don't know

Documentation

  • Does this pull request introduce a new feature? no

@eolivelli eolivelli requested review from codelipenghui and sijie July 6, 2021 07:57
@dlg99
Copy link
Contributor Author

dlg99 commented Jul 6, 2021

/pulsarbot run-failure-checks

@dlg99
Copy link
Contributor Author

dlg99 commented Jul 7, 2021

Currently Pulsar-IO integration tests fail because they got rebased on top #11056 which removed

setConfigIfNull(config, PulsarDatabaseHistory.SERVICE_URL.name(), serviceUrl);

from DebeziumSource but left required parameter PulsarDatabaseHistory.SERVICE_URL in the PulsarDatabaseHistory.

Will deal with this.

@dlg99 dlg99 mentioned this pull request Jul 30, 2021
1 task
@dlg99
Copy link
Contributor Author

dlg99 commented Jul 30, 2021

/pulsarbot run-failure-checks

@sijie
Copy link
Member

sijie commented Aug 4, 2021

@dlg99 Can you rebase this pull request? I have merged #11154

@freeznet @nlu90 please review this PR

Copy link
Member

@nlu90 nlu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sijie sijie merged commit 283ae57 into apache:master Aug 13, 2021
@dlg99 dlg99 deleted the dbz-upgrade branch October 14, 2021 23:31
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Fixes apache#8502

### Motivation

Upgrade Debezium to a newer version

### Modifications

Upgraded Deebzium to v.1.5.4 (latest built with Java 8, v.1.6.x built with Java 11)
Upgraded kafka-client to 2.7 (version debezium tested with)
Scala-lib to 2.13.6 (for kafka-client)

Dealt with API changes, tests etc.

PR is on top of apache#11154 to have Debezium integration tests on CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Debezium to a newer version

5 participants