-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Debezium Oracle Source #11520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debezium Oracle Source #11520
Conversation
|
@dlg99 many thanks for providing doc info! |
sijie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before reviewing this, is there any license issues we should clear out?
|
This is depending on Oracle JDBC driver https://mvnrepository.com/artifact/com.oracle.ojdbc/ojdbc8/19.3.0.0 that is licensed with "Oracle Free Use Terms and Conditions (FUTC)". It's not clear if this license is compatible with ASLv2. |
|
@sijie @merlimat I removed dependency on Oracle JDBC and updated |
|
What about creating one dedicated CI job only for Oracle CDC ? |
eolivelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work
I left some comments about hardcoding 2.9.0-SNAPSHOT, PTAL
pulsar-io/debezium/oracle/src/main/resources/debezium-oracle-source-config.yaml
Show resolved
Hide resolved
pulsar-io/debezium/oracle/src/main/resources/debezium-oracle-source-config.yaml
Show resolved
Hide resolved
pulsar-io/debezium/oracle/src/main/resources/debezium-oracle-source-config.yaml
Show resolved
Hide resolved
…on (trying to avoid timeouts)
eolivelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
great work !
|
Thanks for your great contribution. |
merlimat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@sijie are you okay with merging this PR now ? it looks like licensing issues have been addressed. |
|
ping @sijie |
|
@eolivelli @dlg99 The new integration test seems to be flaky. Here's one sample failure: |
|
Hi @dlg99 for the doc side, I think we already documented "the requirement to download and package Oracle JDBC driver" here(https://pulsar.apache.org/docs/en/next/io-debezium-source/#example-of-oracle)? |
|
@Anonymitaet correct, see #12213 for the docs |
(cherry picked from commit 7b86934)
Motivation
Add Debezium Source for Oracle.
Modifications
Added Debezium Source for Oracle DB.
Added integration test.
Oracle JDBC is not included into nar (licensing issue) so the end user will have to package it.
Dropping jars into the pulsar/lib directory is not enough (connector classpath doesn't get it) so for the integration test I ended up updating the nar file with
jar uf.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
For contributor
For this PR, do we need to update docs?
Need to add description of the new connector; TBD (or will create an issue later).
Need to document requirement to download and package Oracle JDBC driver.