Documentation for Oracle Debezium connector #12213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
approved these changes
Sep 27, 2021
Co-authored-by: Michael Marshall <mikemarsh17@gmail.com>
eolivelli
approved these changes
Sep 27, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Great!
@Anonymitaet PTAL
Anonymitaet
reviewed
Sep 28, 2021
site2/docs/io-debezium-source.md
Outdated
| Debezium [requires](https://debezium.io/documentation/reference/1.5/connectors/oracle.html#oracle-overview) Oracle DB with LogMiner or XStream API enabled. | ||
| Supported options and steps for enabling them vary from version to version of Oracle DB. | ||
| Steps outlined in the [documentation](https://debezium.io/documentation/reference/1.5/connectors/oracle.html#oracle-overview) and used in the [integration test](https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sources/debezium/DebeziumOracleDbSourceTester.java) may or may not work for the version and edition of Oracle DB you are using. | ||
| Please refer to the documentation for Oracle DB as needed. |
Member
There was a problem hiding this comment.
Can you add a reference link here?
| Steps outlined in the [documentation](https://debezium.io/documentation/reference/1.5/connectors/oracle.html#oracle-overview) and used in the [integration test](https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sources/debezium/DebeziumOracleDbSourceTester.java) may or may not work for the version and edition of Oracle DB you are using. | ||
| Please refer to the documentation for Oracle DB as needed. | ||
|
|
||
| Similarly to other connectors, you can use JSON or YAMl to configure the connector. |
Member
There was a problem hiding this comment.
Like other connector docs, can you give a JSON example?
Anonymitaet
added
the
doc
CR feedback Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* Documentation for Oracle Debezium connector * Update site2/docs/io-debezium-source.md Co-authored-by: Michael Marshall <mikemarsh17@gmail.com> * Apply suggestions from code review CR feedback Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com> * CR feedback Co-authored-by: Michael Marshall <mikemarsh17@gmail.com> Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add documentation for new connector.
Modifications
Added documentation.
Verifying this change
This change is a documentation only.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesNo
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?