Skip to content

[Issue #11298]pulsar-daemon script support restart #11299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gaozhangmin wants to merge 3 commits into from
Closed

[Issue #11298]pulsar-daemon script support restart #11299

gaozhangmin wants to merge 3 commits into from

Conversation

@gaozhangmin
Copy link
Contributor

@gaozhangmin gaozhangmin commented Jul 13, 2021 •
edited
Loading

Fixes #11298

Motivation

Add ability to restart service for easy use

Modifications

In pulsar-daemon script, add restart

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API: (yes / no) no
  • The schema: (yes / no / don't know) no
  • The default values of configurations: (yes / no) no
  • The wire protocol: (yes / no) no
  • The rest endpoints: (yes / no) no
  • The admin cli options: (yes / no) no
  • Anything that affects deployment: (yes / no / don't know)no

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not documented

@gaozhangmin gaozhangmin changed the title [Issue ##11298]pulsar-daemon script support restart [Issue #11298]pulsar-daemon script support restart Jul 13, 2021
@gaozhangmin
Copy link
Contributor Author

gaozhangmin commented Jul 13, 2021

Hi @eolivelli Could u please review this pr?

@sijie sijie added this to the 2.9.0 milestone Jul 14, 2021
eolivelli
eolivelli approved these changes Jul 18, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

What about stopping the daemon using '-force'?
Otherwise you are not guaranteed that the process is really killed

@gaozhangmin
Copy link
Contributor Author

gaozhangmin commented Jul 19, 2021

Generally looks good.

What about stopping the daemon using '-force'?
Otherwise you are not guaranteed that the process is really killed

support '-force' argument as before in last commit

@eolivelli eolivelli modified the milestones: 2.9.0, 2.10.0 Oct 6, 2021
@gaozhangmin
Copy link
Contributor Author

gaozhangmin commented Oct 9, 2021

/pulsarbot run-failure-checks

hangc0276
hangc0276 reviewed Oct 11, 2021
View reviewed changes
Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether we should check exit code of stop before calling start method, avoiding stop failed and continue to call start.

@hangc0276
Copy link
Contributor

hangc0276 commented Oct 11, 2021

/pulsarbot run-failure-checks

@gaozhangmin gaozhangmin force-pushed the pulsar-daemon-support-restart branch from 283d053 to c2b6630 Compare October 14, 2021 02:49
@gaozhangmin gaozhangmin force-pushed the pulsar-daemon-support-restart branch from c2b6630 to edb9d64 Compare October 14, 2021 03:01
@gaozhangmin
Copy link
Contributor Author

gaozhangmin commented Oct 14, 2021

/pulsarbot run-failure-checks

@gaozhangmin
Copy link
Contributor Author

gaozhangmin commented Oct 14, 2021

Whether we should check exit code of stop before calling start method, avoiding stop failed and continue to call start.

@hangc0276 done pTAL

@gaozhangmin
Copy link
Contributor Author

gaozhangmin commented Oct 14, 2021

/pulsarbot run-failure-checks

@BewareMyPower
Copy link
Contributor

BewareMyPower commented Oct 14, 2021

It's duplicated with #12279. Close this PR first. If you have some improvement to #12279, please submit a new PR.

@gaozhangmin
Copy link
Contributor Author

gaozhangmin commented Oct 14, 2021

It's duplicated with #12279. Close this PR first. If you have some improvement to #12279, please submit a new PR.

#12279 missed check exit code of stop before calling start method, avoiding stop failed and continue to call start

@BewareMyPower
Copy link
Contributor

BewareMyPower commented Oct 15, 2021

Could you open a new PR to fix it?

@gaozhangmin
Copy link
Contributor Author

gaozhangmin commented Oct 15, 2021

@BewareMyPower #12368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@315157973 315157973 315157973 approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@tuteng tuteng Awaiting requested review from tuteng

@zymap zymap Awaiting requested review from zymap

@eolivelli eolivelli Awaiting requested review from eolivelli

@sijie sijie Awaiting requested review from sijie

Assignees

@gaozhangmin gaozhangmin

Labels

None yet

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

pulsar-daemon script should support restart for easy use

6 participants

@gaozhangmin @hangc0276 @BewareMyPower @sijie @eolivelli @315157973