Skip to content

feat(cli): add restart command to pulsar-daemon #12279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BewareMyPower merged 1 commit into from
Oct 13, 2021
Merged

feat(cli): add restart command to pulsar-daemon #12279

BewareMyPower merged 1 commit into from
Oct 13, 2021

Conversation

@ericsyh
Copy link
Contributor

@ericsyh ericsyh commented Oct 5, 2021

Signed-off-by: Eric Shen ericshenyuhao@outlook.com

Motivation

It's inconvenient to restart the broker/bk/zk process when users change the config, they have use pulsar-daemon stop the process first then start it again.

Modifications

I added a command as restart in pulsar-daemon.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ericsyh
feat(cli): add restart command to pulsar-daemon
e058c88 
Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Oct 13, 2021
@BewareMyPower BewareMyPower merged commit 7273ffe into apache:master Oct 13, 2021
@BewareMyPower BewareMyPower added this to the 2.10.0 milestone Oct 13, 2021
@ericsyh ericsyh deleted the add-restart-cmd-for-pulsar-daemon branch October 13, 2021 02:52
zeo1995 pushed a commit to zeo1995/pulsar that referenced this pull request Oct 14, 2021
Merge branch 'up/master' into website/branch-2.7.2-chapter-2
8b9e28c 
* up/master: (26 commits)
  [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function (apache#12128)
  [website][upgrade]feat: docs migration - Development (apache#12320)
  Update delete inactive topic configuration documentation (apache#12350)
  [PIP 95][Issue 12040][broker] Multiple bind addresses for Pulsar protocol (apache#12056)
  Added Debezium Source for MS SQL Server (apache#12256)
  Fix: flaky oracle tests (apache#12306)
  [C++] Use URL encoded content type for OAuth 2.0 authentication (apache#12341)
  [C++] Handle OAuth 2.0 exceptional cases gracefully (apache#12335)
  feat(cli): add restart command to pulsar-daemon (apache#12279)
  [client-tools] Remove redundant initial value (apache#12296)
  Make AuthenticationTokenTest to run on windows (apache#12329)
  [offload] fix FileSystemManagedLedgerOffloader can not cleanup outdated ledger data (apache#12309)
  [Doc]--Update contents for Pulsar adaptor for Apache Spark (apache#12338)
  [PIP 95][Issue 12040][broker] Improved multi-listener in standalone mode (apache#12066)
  [website][upgrade]feat: docs migration - Cookbooks (apache#12319)
  [testclient] Make --payload-file take effect in PerformanceClient (apache#12187)
  [website][upgrade]feat: docs migration - adaptor (apache#12318)
  [pulsar-client] Add partition-change api for producer/consumer interceptors (apache#12287)
  [Transaction]Fix lowWaterMark of TopicTransactionBuffer (apache#12312)
  [pulsar-admin] New option takes precedence over deprecated option (apache#12260)
  ...

# Conflicts:
#	site2/website-next/docusaurus.config.js
#	site2/website-next/versions.json
@BewareMyPower BewareMyPower mentioned this pull request Oct 14, 2021
Closed
1 task
@gaozhangmin gaozhangmin mentioned this pull request Oct 14, 2021
Merged
@ericsyh ericsyh mentioned this pull request Oct 14, 2021
Merged
3 tasks
zeo1995 pushed a commit to zeo1995/pulsar that referenced this pull request Oct 14, 2021
Merge branch 'up/master' into website/branch-2.7.2
82208c9 
* up/master: (37 commits)
  re-enabling integration tests for Sinks (apache#12307)
  [PIP 95][Issue 12040][web] Topic lookup with listener header (apache#12072)
  Fix the master CI broken with update dispatch rate block issue (apache#12360)
  Fix message being ignored when the non-persistent topic reader reconnect. (apache#12348)
  Fix log format. (apache#12346)
  [website][upgrade]feat: docs migration - version-2.7.2 Concepts and Architecture (apache#12354)
  [website][upgrade] feat: full docs migration for version 2.8.0 (apache#12359)
  [website][upgrade]feat: dynamic replace version info before build (apache#12337)
  Fix flaky tests: ElasticSearchClientTests (apache#12347)
  Use asyncCloseCursorLedger to replace cursorLedger.asyncClose method in the ManagedCursorImpl.VoidCallback#operationComplete (apache#12113)
  fix-npe-ZkBookieRackAffinityMapping (apache#11947)
  [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function (apache#12128)
  [website][upgrade]feat: docs migration - Development (apache#12320)
  Update delete inactive topic configuration documentation (apache#12350)
  [PIP 95][Issue 12040][broker] Multiple bind addresses for Pulsar protocol (apache#12056)
  Added Debezium Source for MS SQL Server (apache#12256)
  Fix: flaky oracle tests (apache#12306)
  [C++] Use URL encoded content type for OAuth 2.0 authentication (apache#12341)
  [C++] Handle OAuth 2.0 exceptional cases gracefully (apache#12335)
  feat(cli): add restart command to pulsar-daemon (apache#12279)
  ...

# Conflicts:
#	site2/website-next/docusaurus.config.js
#	site2/website-next/versioned_sidebars/version-2.7.2-sidebars.json
#	site2/website-next/versions.json
codelipenghui pushed a commit that referenced this pull request Nov 10, 2021
@gaozhangmin
[#12279 ] missed check exit code of stop before calling start (#12368)
aa45ecd 
#12279  missed check exit code of stop before calling start method, avoiding stop failed and continue to call start.

also #12279 has another problem, When restarting with `-force`, `-force` flag will also be passed to `start` by `$@`.
throws` Caused by: org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option: -force`
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
@gaozhangmin @eolivelli
[apache#12279 ] missed check exit code of stop before calling start (a…
1c077fd 
…pache#12368)

apache#12279  missed check exit code of stop before calling start method, avoiding stop failed and continue to call start.

also apache#12279 has another problem, When restarting with `-force`, `-force` flag will also be passed to `start` by `$@`.
throws` Caused by: org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option: -force`
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@ericsyh @splunk-xingw
feat(cli): add restart command to pulsar-daemon (apache#12279)
367ee25 
### Motivation

It's inconvenient to restart the broker/bk/zk process when users change the config, they have use `pulsar-daemon` stop the process first then start it again.

### Modifications

I added a command as `restart` in `pulsar-daemon`.  

Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BewareMyPower BewareMyPower BewareMyPower approved these changes

Assignees

@ericsyh ericsyh

Labels

area/cli doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ericsyh @BewareMyPower @Anonymitaet