[Client] Fix message being ignored when the non-persistent topic reader reconnect.

[RobertIndie]

Motivation

Consumers should not perform message ignore checks when consuming messages from non-persistent topics.
Otherwise, it may lead to a case where the message is incorrectly ignored when the non-persistent reader(or non-durable subscription non-persistent consumer) reconnects to the broker.

Currently, when the reader of the non-persistent topic has its currentMessageQueue empty before reconnection, its startMessageId is set to lastDequeuedMessageId after reconnection:

pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java

Line 856 in 4ae7f6a

return new BatchMessageIdImpl((MessageIdImpl) lastDequeuedMessageId);

and if we specify startMessageId as the default value (-1:-1), it will be set to (0:0) after reconnection, thus causes all subsequent messages to be ignored:

pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java

Lines 1202 to 1211 in 4ae7f6a

	if (isSameEntry(msgId) && isPriorEntryIndex(messageId.getEntryId())) {
	// We need to discard entries that were prior to startMessageId
	if (log.isDebugEnabled()) {
	log.debug("[{}] [{}] Ignoring message from before the startMessageId: {}", subscription,
	consumerName, startMessageId);
	}
	uncompressedPayload.release();
	return;
	}

and for batch messages here:

pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java

Lines 1029 to 1037 in 4ae7f6a

	if (isSameEntry(messageId) && isPriorBatchIndex(index)) {
	// If we are receiving a batch message, we need to discard messages that were prior
	// to the startMessageId
	if (log.isDebugEnabled()) {
	log.debug("[{}] [{}] Ignoring message from before the startMessageId: {}", subscription,
	consumerName, startMessageId);
	}
	return null;
	}

Modifications

• Remove the message ignore check when the topic of the consumer is non-persistent

Verifying this change

This change is already covered by existing tests, such as testReaderReconnectAndRead and testReaderReconnectAndReadBatchMessages.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API: (no)
• The schema: (no)
• The default values of configurations: (no)
• The wire protocol: (no)
• The rest endpoints: (no)
• The admin cli options: (no)
• Anything that affects deployment: (no)

Documentation

• no-need-doc

This is a bug fix.

[hangc0276]

Nice Catch!