[Issue 11440]. Add complete metadata for admin.topics().examineMessages #11443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Jul 23, 2021
sijie
added
area/admin
doc-required
codelipenghui
approved these changes
Jul 24, 2021
Contributor
|
@Jason918 Please check the checkstyle issue |
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
@codelipenghui |
Member
|
@Jason918 thanks for your great work. Would you like to add docs accordingly? Then you can ping me to review, thanks |
Contributor
Author
@Anonymitaet It seems there're no user docs for examine-message cmd. So I added new section for it. Please check it out in my last commit. |
codelipenghui
pushed a commit
that referenced
this pull request
Jul 30, 2021
…es (#11443) Fixes #11440 see issue 11440 Add all the other non-empty meta data fields in http response headers in `org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#generateResponseWithEntry`. For fields with byte[] type, base64 is used for serialization and deserialization. (cherry picked from commit afe4792)
Anonymitaet
added
doc
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…es (apache#11443) Fixes apache#11440 ### Motivation see issue 11440 ### Modifications Add all the other non-empty meta data fields in http response headers in `org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#generateResponseWithEntry`. For fields with byte[] type, base64 is used for serialization and deserialization.
momo-jun
added a commit
to momo-jun/pulsar
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11440
Motivation
see issue 11440
Modifications
Add all the other non-empty meta data fields in http response headers in
org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#generateResponseWithEntry. For fields with byte[] type, base64 is used for serialization and deserialization.Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
org.apache.pulsar.broker.admin.PersistentTopicsTest#testExamineMessageMetadataDoes this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation