[websocket] Query parameter "negativeAckRedeliveryDelay" should be effective even if DLQ is disabled

[massakam]

Motivation

On the consumer endpoint of WebSocket API, we can specify the delay time before a message which is negatively acknowledged is redelivered using the query parameter negativeAckRedeliveryDelay.

However, this parameter is currently ignored when DLQ is disabled. I think this is an implementation mistake. Users should be able to specify negativeAckRedeliveryDelay even if DLQ is disabled.

pulsar/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java

Lines 389 to 403 in ee202d0

	if (queryParams.containsKey("maxRedeliverCount") || queryParams.containsKey("deadLetterTopic")) {
	DeadLetterPolicy.DeadLetterPolicyBuilder dlpBuilder = DeadLetterPolicy.builder();
	if (queryParams.containsKey("maxRedeliverCount")) {
	dlpBuilder.maxRedeliverCount(Integer.parseInt(queryParams.get("maxRedeliverCount")))
	.deadLetterTopic(String.format("%s-%s-DLQ", topic, subscription));
	}
	if (queryParams.containsKey("deadLetterTopic")) {
	dlpBuilder.deadLetterTopic(queryParams.get("deadLetterTopic"));
	}
	if (queryParams.containsKey("negativeAckRedeliveryDelay")) {
	builder.negativeAckRedeliveryDelay(Integer.parseInt(queryParams.get("negativeAckRedeliveryDelay")), TimeUnit.MILLISECONDS);
	}
	builder.deadLetterPolicy(dlpBuilder.build());
	}

Related PR: #8249

Modifications

Fixed ConsumerHandler of WebSocket to use the negativeAckRedeliveryDelay value specified by the client even if DLQ is disabled. In addition, fixed an inappropriate test code (ProxyPublishConsumeTest#nackMessageTest()).

Verifying this change

• Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API: (yes)
• The schema: (no)
• The default values of configurations: (no)
• The wire protocol: (no)
• The rest endpoints: (no)
• The admin cli options: (no)
• Anything that affects deployment: (no)

[Anonymitaet]

Thanks for your contribution. I’ve left some comments, PTAL.

[massakam]

@Anonymitaet Addressed your comment. PTAL

[Anonymitaet]

Thanks for your contribution. Approved from the language perspective.