[Transaction] Fix transaction flaky test testMaxReadPositionForNormal… #12681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@congbobo184:Thanks for your contribution. For this PR, do we need to update docs? |
|
@congbobo184:Thanks for providing doc info! |
Contributor
|
@congbobo184 could you please add more context about the flaky test and how it will be fixed by this PR? |
added 2 commits
November 12, 2021 18:07
…tMaxReadPositionForNormalPublish
…tMaxReadPositionForNormalPublish
codelipenghui
approved these changes
Nov 18, 2021
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Nov 18, 2021
* up/master: Update deploy-bare-metal.md (apache#12432) [Broker] Fix producer getting incorrectly removed from topic's producers map (apache#12846) Add error log when new jetty client (apache#12840) JavaInstanceTest should be AssertEquals (apache#12836) [Transaction] Fix transaction flaky test testMaxReadPositionForNormalPublish (apache#12681) The problem of two exception handling (apache#12744) Fix TopicPoliciesCacheNotInitException issue. (apache#12773) Added local filesystem backend for package manager (apache#12708) [Java Client] Make userProvidedProducerName final (apache#12849) optimize indention in ServerCnx#handleProducer (apache#12854)
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Nov 18, 2021
* up/master: [Issue 12757][broker] add broker config isAllowAutoUpdateSchema (apache#12786) Update deploy-bare-metal.md (apache#12432) [Broker] Fix producer getting incorrectly removed from topic's producers map (apache#12846) Add error log when new jetty client (apache#12840) JavaInstanceTest should be AssertEquals (apache#12836) [Transaction] Fix transaction flaky test testMaxReadPositionForNormalPublish (apache#12681) The problem of two exception handling (apache#12744) Fix TopicPoliciesCacheNotInitException issue. (apache#12773) Added local filesystem backend for package manager (apache#12708)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 23, 2021
…Publish (apache#12681) ## Motivation fix flaky test apache#12671 `publishContext.completed(null, position.getLedgerId(), position.getEntryId())` before `transactionBuffer.syncMaxReadPositionForNormalPublish((PositionImpl) ledger.getLastConfirmedEntry())` so return messageId for client, dont represent broker syncMaxReadPositionForNormalPublish complete
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…Publish (apache#12681) ## Motivation fix flaky test apache#12671 `publishContext.completed(null, position.getLedgerId(), position.getEntryId())` before `transactionBuffer.syncMaxReadPositionForNormalPublish((PositionImpl) ledger.getLastConfirmedEntry())` so return messageId for client, dont represent broker syncMaxReadPositionForNormalPublish complete
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…Publish (apache#12681) ## Motivation fix flaky test apache#12671 `publishContext.completed(null, position.getLedgerId(), position.getEntryId())` before `transactionBuffer.syncMaxReadPositionForNormalPublish((PositionImpl) ledger.getLastConfirmedEntry())` so return messageId for client, dont represent broker syncMaxReadPositionForNormalPublish complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix flaky test #12671
so return messageId for client, dont represent broker syncMaxReadPositionForNormalPublish complete