[Java Client] Make userProvidedProducerName final #12849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhangjian
approved these changes
Nov 17, 2021
lhotari
approved these changes
Nov 17, 2021
Member
Author
|
/pulsarbot run-failure-checks |
RobertIndie
approved these changes
Nov 17, 2021
Technoboy-
approved these changes
Nov 17, 2021
eolivelli
approved these changes
Nov 17, 2021
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Nov 18, 2021
* up/master: Update deploy-bare-metal.md (apache#12432) [Broker] Fix producer getting incorrectly removed from topic's producers map (apache#12846) Add error log when new jetty client (apache#12840) JavaInstanceTest should be AssertEquals (apache#12836) [Transaction] Fix transaction flaky test testMaxReadPositionForNormalPublish (apache#12681) The problem of two exception handling (apache#12744) Fix TopicPoliciesCacheNotInitException issue. (apache#12773) Added local filesystem backend for package manager (apache#12708) [Java Client] Make userProvidedProducerName final (apache#12849) optimize indention in ServerCnx#handleProducer (apache#12854)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 23, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
userProvidedProducerNamevariable in the Java ClientProducerImplcan easily be madefinal. Making it final helps make it clear that this value should not change once the producer is created.Modifications
userProvidedProducerNamefinal.userProvidedProducerNameis instantiated.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
no-need-docThis is a very minor internal change.