[C++] Fix in macOS CMake might find error boost-python libs path #13193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
BewareMyPower,
aahmed-se,
jiazhai,
merlimat and
rdhabalia
BewareMyPower
approved these changes
Dec 8, 2021
Member
Author
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Dec 9, 2021
BewareMyPower
added
release/2.7.4
release/2.8.3
release/2.9.1
and removed
release/2.7.4
labels
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2021
(cherry picked from commit fdfea8a)
zymap
pushed a commit
that referenced
this pull request
Dec 23, 2021
(cherry picked from commit fdfea8a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11747
Motivation
In macOS, when CMake sets a variable like
Boost_PYTHON37-MT_LIBRARY_RELEASE, we need to check this value exists, otherwise might get aBoost_PYTHON37-MT_LIBRARY_RELEASE-NOTFOUND.Modifications
Check the value is exists before we used it.
Documentation
Need to update docs?
no-need-doc