Enforce boost-python was found by CMake #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Sep 19, 2018
Contributor
Author
|
run cpp tests |
Comment on lines
+51
to
+54
| if (APPLE) | ||
| set(PYTHON_WRAPPER_LIBS ${PYTHON_WRAPPER_LIBS} | ||
| ${Boost_PYTHON27-MT_LIBRARY_RELEASE} ${Boost_PYTHON37-MT_LIBRARY_RELEASE}) | ||
| endif() |
Contributor
Contributor
There was a problem hiding this comment.
BTW, here is a fix: #13193. But IMO these code could be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure the CMake preparation fails when the correct Boost-Python library is not found. With the current behavior, the build goes through even when not found, and then the resulting
_pulsar.sowill not be linked with boost-python and will fail to load at runtime.