[fix][broker]: Fix cannot delete namespace with system topic #14730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
approved these changes
Mar 18, 2022
codelipenghui
approved these changes
Mar 18, 2022
codelipenghui
added
type/bug
codelipenghui
changed the title
Contributor
Author
|
Hi @michaeljmarshall @shibd @dave2wave @RobertIndie Could you help review this ? |
RobertIndie
approved these changes
Mar 20, 2022
shibd
approved these changes
Mar 21, 2022
Member
shibd
left a comment
shibd
left a comment
There was a problem hiding this comment.
Good idea! I tested with standalone, and the problem no reproduce.
Contributor
Author
|
@Jason918 @yuruguo @wolfstudy Could you please help review ? |
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
Outdated
Show resolved
Hide resolved
Demogorgon314
approved these changes
Mar 21, 2022
Jason918
reviewed
Mar 21, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
Outdated
Show resolved
Hide resolved
gaoran10
approved these changes
Mar 22, 2022
Jason918
approved these changes
Mar 22, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Mar 25, 2022
(cherry picked from commit 7556c4e)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 4, 2022
(cherry picked from commit 7556c4e)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 5, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
(cherry picked from commit 7556c4e)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10263
Master Issue: #10263
Motivation
When deleting namespace, the namespace policy is set to
delete=true, but we don't check this state anymore. We should check this state at the get-policy stage.After adding this check, topic lookup, get partitioned metadata will contain this logic, so we could resolve #10263.
Because when delete namespace, it will set this state first and delete all the topics. But if enabled topic auto-creation, all the pre-connected client will try to reconnect, and they will do lookup, but get the 'Namespace is deleted' exception,
and then get
Namespace not foundexception:These two exceptions will block clients connecting to the broker. so #10263 will be resolved.
Related email discuss here: https://lists.apache.org/thread/p4tmgk23l8j554bjr4h4ofk97bll5gp4
Documentation
no-need-doc