Issue 17588: Allow deletion of a namespace that was left in deleted status #17592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested review from
Technoboy-,
codelipenghui,
dlg99 and
nicoloboschi
nicoloboschi
approved these changes
Sep 12, 2022
codelipenghui
approved these changes
Sep 13, 2022
Technoboy-
approved these changes
Sep 13, 2022
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Jason918
approved these changes
Sep 13, 2022
eolivelli
force-pushed
the
fix/error-delete-partially-deleted-namespace
branch
from
e0097b1 to
2895cf2
Compare
congbobo184
pushed a commit
to congbobo184/pulsar
that referenced
this pull request
Dec 1, 2022
…nd flaky test testFailoverSingleAckedPartitionedTopic
congbobo184
added a commit
that referenced
this pull request
Dec 4, 2022
…ky test testFailoverSingleAckedPartitionedTopic (#18702) Co-authored-by: congbobo184 <congbobo184@github.com> Co-authored-by: Jiwe Guo <technoboy@apache.org> ### Motivation 1. add missing code for cherry-pick #17592 2. fix flaky test testFailoverSingleAckedPartitionedTopic. redeliver in another thread will cause receive repeat messages. 3. run test for branch-2.9
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17588
Motivation
In Pulsar 2.10.1 with #14730 we introduced a check about concurrent deletion of Namespaces.
This broke the deletion of namespaces in case of a partial failure.
When you delete a namespace we collect all the resources, then we mark the namespace as "deleted", then we do the deletion.
if some failure happens and the procedure does not complete, then the namespaces stays in "deleted" status.
And if you try to delete it again you see the error in #17588 "The namespace is deleted", because getListOfNonPersistentTopics() performs a check about the status of the namespace.
Modifications
Do not check the flag "Policies.deleted" while listing non-persistent topics.è
Verifying this change
I added a test case that fails without this fix
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededIt is a bug fix for a regression
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)