[feature][Doc] Add doc for CommandAckResponse
#15497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation Now, the website do not have related doc of `CommandAckResponse`. ### Modification Add the doc for `CommandAckResponse`.
github-actions
bot
added
the
doc
RobertIndie
reviewed
May 9, 2022
Co-authored-by: Zike Yang <zike@apache.org>
momo-jun
reviewed
May 9, 2022
momo-jun
reviewed
May 9, 2022
momo-jun
reviewed
May 9, 2022
momo-jun
reviewed
May 9, 2022
momo-jun
approved these changes
May 9, 2022
Contributor
|
Two more suggestions:
|
liangyepianzhou
changed the title
CommandAckResponseCommandAckResponse
Contributor
Author
In fact, the ACK Response has existed for a long time, and this PR just adds a request ID. This is also the reason why I didn't add this PR link before. |
Contributor
|
Does this doc change apply to version 2.8 or later? If yes, more historical versions of docs need update (site2/website/versioned_docs). |
codelipenghui
approved these changes
May 9, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now, the website do not have related doc of
CommandAckResponsein #8996.Modification
Add the doc for
CommandAckResponse.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)