[feature][doc] Add docs for Command AckResponse to historical versions #15507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@momo-jun:Thanks for your contribution. For this PR, do we need to update docs? |
Contributor
Author
|
@liangyepianzhou can you pls review the PR? |
|
@momo-jun:Thanks for providing doc info! |
github-actions
bot
added
the
doc
liangyepianzhou
approved these changes
May 9, 2022
Huanli-Meng
reviewed
May 10, 2022
Contributor
Huanli-Meng
left a comment
Huanli-Meng
left a comment
There was a problem hiding this comment.
leave some minor comments. PTAL
site2/website/versioned_docs/version-2.8.0/developing-binary-protocol.md
Outdated
Show resolved
Hide resolved
site2/website/versioned_docs/version-2.8.0/developing-binary-protocol.md
Outdated
Show resolved
Hide resolved
site2/website/versioned_docs/version-2.8.0/developing-binary-protocol.md
Outdated
Show resolved
Hide resolved
Anonymitaet
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
CommandAckResponse#15497 for Command AckResponse to historical versions.Documentation
doc