[enh] Issue 15455: Pulsar Admin: create subscripion with Properties (PIP-105) #15503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested review from
315157973 and
RobertIndie
and removed request for
315157973
eolivelli
force-pushed
the
impl/pip105-create-subscription-admin-properties
branch
from
60098be to
4a0f7fd
Compare
eolivelli
assigned
hangc0276,
315157973,
codelipenghui and
eolivelli and unassigned
hangc0276,
eolivelli,
315157973 and
codelipenghui
eolivelli
changed the title
eolivelli
requested review from
dlg99,
lhotari,
michaeljmarshall and
nicoloboschi
Member
mattisonchao
left a comment
mattisonchao
left a comment
There was a problem hiding this comment.
Overall LGTM, Could we add a test for REST API with properties? Looks like we just have a test for cli.
eolivelli
force-pushed
the
impl/pip105-create-subscription-admin-properties
branch
from
f6f824e to
4fe43a2
Compare
Contributor
Author
|
/pulsarbot rerun-failure-checks |
2 similar comments
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
eolivelli
added a commit
to eolivelli/pulsar
that referenced
this pull request
May 20, 2022
…PIP-105) (apache#15503) (cherry picked from commit e2fa189)
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
May 23, 2022
…PIP-105) (apache#15503) (apache#15681) (cherry picked from commit e2fa189)
nicoloboschi
added a commit
that referenced
this pull request
May 27, 2022
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15455
Motivation
We are missing tools to manage Subscription properties introduces in PIP-105.
Modifications
Add initial support to "create subscription" in PulsarAdmin API (Java and CLI) to pass subscription properties.
The properties are passed as a query string parameter in order to keep compatibility with the old API and do not require a new API.
Verifying this change
This patch adds tests
Documentation
The documentation of pulsar-admin and PulsarAdmin is automatically generated, no need to do anything more