Skip to content

[fix][broker] Copy subscription properties during updating the topic partition number. #19223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattisonchao merged 3 commits into from
Jan 13, 2023
Merged

[fix][broker] Copy subscription properties during updating the topic partition number. #19223

mattisonchao merged 3 commits into from
Jan 13, 2023

Conversation

@mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Jan 13, 2023

Motivation

we have supported creating a subscription with properties since #15503. It is a good way to support copy subscription properties during updating the topic partition number.

Because #15503 didn't support v1, this PR also just focused on v2.

Modifications

  • Support copy subscription properties during updating the topic partition number.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao self-assigned this Jan 13, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 13, 2023
@mattisonchao mattisonchao added this to the 2.12.0 milestone Jan 13, 2023
@mattisonchao mattisonchao reopened this Jan 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023 •
edited
Loading

Codecov Report

Merging #19223 (516d009) into master (d7f8f56) will decrease coverage by 2.54%.
The diff coverage is 26.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19223      +/-   ##
============================================
- Coverage     47.89%   45.34%   -2.55%     
- Complexity    10871    10947      +76     
============================================
  Files           713      773      +60     
  Lines         69730    74512    +4782     
  Branches       7496     8030     +534     
============================================
+ Hits          33394    33788     +394     
- Misses        32631    36933    +4302     
- Partials       3705     3791      +86
Flag Coverage Δ
unittests 45.34% <26.66%> (-2.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pulsar/client/impl/ProducerImpl.java 15.62% <0.00%> (-0.04%) ⬇️
...e/pulsar/client/impl/schema/reader/JsonReader.java 0.00% <0.00%> (ø)
...r/client/impl/schema/reader/JacksonJsonReader.java 66.66% <66.66%> (-6.67%) ⬇️
...pulsar/broker/admin/impl/PersistentTopicsBase.java 58.90% <100.00%> (-0.76%) ⬇️
...ice/streamingdispatch/PendingReadEntryRequest.java 0.00% <0.00%> (-68.19%) ⬇️
...ervice/streamingdispatch/StreamingEntryReader.java 0.00% <0.00%> (-56.73%) ⬇️
...istentStreamingDispatcherSingleActiveConsumer.java 0.00% <0.00%> (-50.52%) ⬇️
...ersistentStreamingDispatcherMultipleConsumers.java 0.00% <0.00%> (-45.55%) ⬇️
...ar/broker/loadbalance/impl/BundleSplitterTask.java 54.00% <0.00%> (-28.00%) ⬇️
...g/apache/bookkeeper/mledger/util/StatsBuckets.java 43.75% <0.00%> (-16.67%) ⬇️
... and 105 more

@mattisonchao mattisonchao merged commit 253e3e4 into apache:master Jan 13, 2023
@mattisonchao mattisonchao deleted the support_copy_properties branch January 13, 2023 12:05
liangyepianzhou pushed a commit that referenced this pull request Feb 7, 2023
@mattisonchao @liangyepianzhou
[improve][broker] Copy subscription properties during updating the to…
05cbbfd 
…pic partition number. (#19223)

(cherry picked from commit 253e3e4)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Feb 28, 2023
@mattisonchao @nicoloboschi
[improve][broker] Copy subscription properties during updating the to…
9ad4925 
…pic partition number. (apache#19223)

(cherry picked from commit 253e3e4)
(cherry picked from commit 05cbbfd)
@mattisonchao mattisonchao mentioned this pull request Mar 14, 2023
Merged
1 task
@mattisonchao mattisonchao changed the title [improve][broker] Copy subscription properties during updating the topic partition number. [fix][broker] Copy subscription properties during updating the topic partition number. Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@eolivelli eolivelli eolivelli approved these changes

@AnonHxy AnonHxy AnonHxy approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@coderzc coderzc coderzc approved these changes

@congbobo184 congbobo184 congbobo184 approved these changes

Assignees

@mattisonchao mattisonchao

Labels

cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs ready-to-test release/2.10.4 release/2.11.1

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@mattisonchao @codecov-commenter @Technoboy- @eolivelli @AnonHxy @codelipenghui @coderzc @congbobo184 @liangyepianzhou