[fix][tiered-storage] Fix the wrong secret key name get from env #15814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Fix the wrong secret key name getting from env
zymap
added
type/bug
|
@zymap:Thanks for your contribution. For this PR, do we need to update docs? |
zymap
added
doc-not-needed
Technoboy-
approved these changes
May 27, 2022
hangc0276
approved these changes
May 27, 2022
Member
Author
|
It's a fix for #15710 |
mattisonchao
pushed a commit
that referenced
this pull request
Aug 25, 2022
michaeljmarshall
pushed a commit
that referenced
this pull request
Aug 30, 2022
) (cherry picked from commit d87cab2)
5 tasks
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 30, 2022
…che#15814) (cherry picked from commit d87cab2) (cherry picked from commit fc8d32d)
zymap
added a commit
that referenced
this pull request
Sep 15, 2022
) (cherry picked from commit d87cab2)
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the wrong secret key name getting from env
Motivation
Fix the wrong secret key name getting from env
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)