Skip to content

Conversation

@yapxue
Copy link
Contributor

@yapxue yapxue commented Aug 22, 2022

Motivation

There is a typo in JCloudBlobStoreProvider. It can cause 403 when use S3 as long term storage

Modifications

fix typo from ACCESS_KEY_ID to ACCESS_KEY_SECRET

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no )

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 22, 2022
@dave2wave
Copy link
Member

dave2wave commented Aug 30, 2022

Without this change do you get an error like:

 Caused by: org.jclouds.aws.AWSResponseException: request POST https://s3.us-west-2.amazonaws.com/lunastreaming-omb-testing-1?delete HTTP/1.1 failed with code 403, error: AWSError{requestId='**********************', requestToken='****************************************=', code='SignatureDoesNotMatch'

@michaeljmarshall
Copy link
Member

Thank you for your contribution @yapxue! It looks like this was already fixed in #15814. Our project targets fixes to master and then cherry-picks them to affected release branches. I just cherry picked this fix to branch-2.10. I am going to close this PR since the change is already present. Please let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants