Skip to content

Conversation

@Demogorgon314
Copy link
Member

Motivation

After #12647, the schema not found exception message is replaced by Schema not found, so the AdminApiSchemaValidationEnforced test will always fail.

java.lang.AssertionError: 
Expected :true
Actual   :false
<Click to see difference>


  at org.testng.Assert.fail(Assert.java:99)
  at org.testng.Assert.failNotEquals(Assert.java:1037)
  at org.testng.Assert.assertTrue(Assert.java:45)
  at org.testng.Assert.assertTrue(Assert.java:55)
  at org.apache.pulsar.broker.admin.AdminApiSchemaValidationEnforced.testDisableSchemaValidationEnforcedHasSchema(AdminApiSchemaValidationEnforced.java:105)
// ...

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 27, 2022
@Technoboy- Technoboy- added this to the 2.11.0 milestone May 27, 2022
@Demogorgon314
Copy link
Member Author

/pulsarbot run-failure-checks

@Demogorgon314
Copy link
Member Author

/pulsarbot run-failure-checks

@BewareMyPower
Copy link
Contributor

It's an early PR, I'm wondering why could the CI still pass?

@Demogorgon314
Copy link
Member Author

It's an early PR, I'm wondering why could the CI still pass?

Maybe because the test unit class name did not end with Test? After adding the Test suffix, it is running well in my local env.

Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Demogorgon314 Please help check the failed test.

@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/fix-unit-test-check-schema-not-found branch from 2ffac41 to b66d952 Compare June 9, 2022 09:20
@Demogorgon314
Copy link
Member Author

/pulsarbot run-failure-checks

@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/fix-unit-test-check-schema-not-found branch from b66d952 to 19f1da7 Compare June 10, 2022 07:08
@Demogorgon314
Copy link
Member Author

/pulsarbot run-failure-checks

1 similar comment
@Demogorgon314
Copy link
Member Author

/pulsarbot run-failure-checks

@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/fix-unit-test-check-schema-not-found branch from 19f1da7 to 25a8720 Compare June 16, 2022 03:52
@Demogorgon314
Copy link
Member Author

/pulsarbot run-failure-checks

1 similar comment
@Demogorgon314
Copy link
Member Author

/pulsarbot run-failure-checks

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Jul 21, 2022
@Jason918
Copy link
Contributor

@Demogorgon314 Please rebase to the master.

@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/fix-unit-test-check-schema-not-found branch from 25a8720 to 83808b2 Compare August 27, 2022 09:23
@github-actions github-actions bot removed the Stale label Aug 28, 2022
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/fix-unit-test-check-schema-not-found branch from 83808b2 to eadc2d6 Compare September 9, 2022 01:18
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Oct 9, 2022
@Demogorgon314
Copy link
Member Author

PR #17767 already fixed this issue, so I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants