rename pulsar env variables for pulsar tools #16623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
approved these changes
Jul 15, 2022
|
The pr had no activity for 30 days, mark with Stale label. |
dave2wave
approved these changes
Oct 21, 2022
tisonkun
requested changes
Nov 14, 2022
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
I'm afraid that this patch causes breaking changes because users can depend on this env var (PULSAR_MEM) to set the memory when running tools.
Member
|
Close as no consensus. I suggest you start a thread on the dev@ mailing list for such breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As #4105, we could config pulsar in container environments through environment variables.
Current, both broker and pulsar tools (admin, client, perf) use
PULSAR_MEMto config jvm memory.Consider we create a pod for broker through kubernetes, we set
containers.resources.limits.memoryto 25Gi, set envPULSAR_MEMto-Xms10g -Xmx10g -XX:MaxDirectMemorySize=10g, broker will start with this jvm memory config.When we run pulsar-admin or pulsar-client in this pod, they will start with broker's jvm memory config since
PULSAR_MEMwas already set, that will cause pod's total memory exceed the limit.Modifications
Rename
PULSAR_MEMtoPULSAR_TOOL_MEMfor pulsar tools, we could setPULSAR_TOOL_MEMthrough environment variables for pulsar tools, or just use the default jvm memory setting.Verifying this change
This change is a trivial rework
Documentation
doc-not-needed