Skip to content

Conversation

@cckellogg
Copy link
Contributor

Motivation

Allow the setting of pulsar environment variables from the environment. This makes it easier to configure pulsar in container environments and reduces the need to use a script to do a search and replace on environment variables.

Modifications

Only set pulsar environment variables if they are not already set in the pulsar_env.sh file. Apply the PULSAR_MEM and PULSAR_GC in the pulsar bin file.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: ( no)
  • The schema: (no)
  • The default values of configurations: ( no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@merlimat merlimat added this to the 2.4.0 milestone Apr 23, 2019
@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Apr 23, 2019
@merlimat merlimat merged commit bd7b0cf into apache:master Apr 23, 2019
lhotari added a commit to lhotari/datastax-pulsar-helm-chart that referenced this pull request Mar 21, 2022
- this is obsolete after apache/pulsar#6579, apache/pulsar#4105 and apache/pulsar#5892
  changes. apply-config-from-env.py doesn't properly handle replacements for shell scripts
lhotari added a commit to datastax/pulsar-helm-chart that referenced this pull request Mar 21, 2022
…163)

- this is obsolete after apache/pulsar#6579, apache/pulsar#4105 and apache/pulsar#5892
  changes. apply-config-from-env.py doesn't properly handle replacements for shell scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants